Skip to content

Fix Former Student part III reward not triggering #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayH2971 wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix Former Student part III reward not triggering #2719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fbb96bd
Fix Former Student part III reward not triggering
JayH2971 Jan 24, 2025
fdc75a2
Formatting fixes Former Student III
JayH2971 Jan 24, 2025
a2f28f9
Adds death timer to Former Student III
JayH2971 Jan 24, 2025
4dc8e91
Order of events fixed in K0C01Y00
JayH2971 Mar 4, 2025
4738471
Quest updates vol 1, mostly text (Fighters Guild)
JayH2971 Mar 7, 2025
7cb1e2b
BOB50Y11 The Exorcism insta-victory fix
JayH2971 Mar 24, 2025
2c9fdf5
Increases rep requirement for The Lost Child quest
JayH2971 May 16, 2025
084d75c
Merge branch 'master' into master
Daneel53 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion Assets/StreamingAssets/Quests/B0B50Y11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ QuestComplete: [1004]
<ce> to dedicate a fountain in
<ce> your name.

--%g is always lowercase, so changed the sentence
--structure here to allow it

RumorsDuringQuest: [1005]
_nobleman_ was crazy to accept the deed to ___dungeon_. Crazy or stupid.

Expand All @@ -58,13 +61,17 @@ You failed %kno when you failed _nobleman_, %pcf. A grave disappointment.
QuestLogEntry: [1010]
%qdt:
_qgiver_ of
==qgiver_ in ___qgiver_
__qgiver_ in ___qgiver_
pled with me to rid ___dungeon_
of a ghost that is haunting
it. I have =2dung_ days before
they need to begin
the reconstruction.

--changed ==qigver_ to __qgiver_ as this guarantees
--showing the building name of the questgiver,
--which is fine for a temple

Message: 1011
<ce> The ghost has been laid to
<ce> rest. _nobleman_ can now
Expand Down Expand Up @@ -113,11 +120,19 @@ _S.01_ task:

_S.02_ task:
clicked npc _qgiver_

_wincondition_ task:
when _S.01_ and _S.02_
give pc nothing
change repute with _local_ by +4
change repute with _nobleman_ by +10
end quest

--added this new wincondition task
--as previously the quest could be
--insta-completed by clicking on questgiver alone,
--quest depended too much on clearclick

_clearclick_ task:
when _S.02_ and not _S.01_
clear _S.02_ _clearclick_
Expand Down
14 changes: 8 additions & 6 deletions Assets/StreamingAssets/Quests/K0C01Y00.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,14 @@ _S.10_ task:
say 1019
start task _victory_

_S.13_ task:
toting _gem_ and _qgiver_ clicked
give pc _gold_
end quest
-- this action was below "pcgetgold" below, and it turns out DFU's order of operations
-- locked out this action because it was later in the quest file. With this move,
-- the toting action works properly and quest can be completed with this.

variable _victory_
_S.11_ task:
clicked item _gem_
Expand All @@ -263,12 +271,6 @@ _clearclick_ task:
when _qgclicked_ and not _victory_
clear _clearclick_ _qgclicked_

_S.13_ task:
toting _gem_ and _qgiver_ clicked
give pc _gold_
end quest
--added victory condition here, per message block 1002

_S.14_ task:
when _S.10_ or _S.08_
-or _S.13_
Expand Down
6 changes: 3 additions & 3 deletions Assets/StreamingAssets/Quests/M0B00Y06.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ QuestorOffer: [1000]
<ce> It seems a wild animal has gotten into
<ce> his place. We need someone to go kill
<ce> the thing. The guild will pay _gold_ gold.
<ce> Do you want it %pcn?
<ce> Do you want it, %pcn?

RefuseQuest: [1001]
<ce> I'm sure someone else will
<ce> be willing to take care of
<ce> this nuisance bear.
<ce> this nuisance animal.

AcceptQuest: [1002]
<ce> "OK, %pcf. Get over to _house_
Expand All @@ -46,7 +46,7 @@ RumorsPostfailure: [1006]
That creature mauled some woman before being chased out of town. What a pity.

RumorsPostsuccess: [1007]
The Fighters Guild killed that bear that got into _house_. It's a good thing we have them around.
The Fighters Guild killed that animal that got into _house_. It's a good thing we have them around.

QuestorPostsuccess: [1008]
Good job killin' that beast. What can I do for you?
Expand Down
12 changes: 6 additions & 6 deletions Assets/StreamingAssets/Quests/M0B00Y07.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@ QuestComplete: [1004]
<ce> your _gold_ gold.

RumorsDuringQuest: [1005]
<ce> I hear there's a tiger trapped in
<ce> _house_. He's going to have
<ce> I hear there's an animal trapped in
<ce> _house_. Someone's going to have
<ce> to pay to get it slain.

RumorsPostfailure: [1006]
A tiger killed some poor bloke in his own home. A terrible tragedy.
A beast killed some poor bloke in his own home. A terrible tragedy.

RumorsPostsuccess: [1007]
Didn't you kill that rampaging tiger that got into _house_?
Didn't you kill that rampaging animal that got into _house_?

QuestorPostsuccess: [1008]
Good going with that tiger.
Good going with that beast.

QuestorPostfailure: [1009]
Tigers are tough. Maybe we should start you out with chipmunks. What a putz.
Beasts are tough. Maybe we should start you out with chipmunks. What a putz.

QuestLogEntry: [1010]
%qdt:
Expand Down
19 changes: 11 additions & 8 deletions Assets/StreamingAssets/Quests/M0B00Y15.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,43 +29,46 @@ RefuseQuest: [1001]
<ce> tell them what you really think.

AcceptQuest: [1002]
<ce> The bats have infested _house_.
<ce> The animals have infested _house_.
<ce> Go there and kill them all and you'll
<ce> get your pay. I can only give you one
<ce> day to finish this one.

QuestComplete: [1004]
<ce> Killing bats, even giant ones,
<ce> Killing pests, even giant ones,
<ce> doesn't take much skill, but it
<ce> pays the same, eh?

RumorsDuringQuest: [1005]
<ce> Some idiot didn't repair her roof
<ce> for a couple of months. Now she's
<ce> got giant bats in her house.
<ce> got giant rodents in her house.

RumorsPostfailure: [1006]
<ce> Did you hear about the woman that
<ce> had to abandon her home? It was
<ce> overrun with giant bats and she
<ce> overrun with giant rodents and she
<ce> didn't have enough gold to pay the
<ce> Fighters Guild to kill them.

RumorsPostsuccess: [1007]
<ce> I heard the Fighters Guild sent some
<ce> %ra over to kill the bats in that
<ce> %ra over to kill the creatures in that
<ce> woman's home. Cost her a bundle, but
<ce> I suppose it's better than abandoning
<ce> her home.

QuestorPostsuccess: [1008]
<ce> So you killed the giant bats. Don't
<ce> So you killed the giant rodents. Don't
<ce> get too full of yourself. They were
<ce> only giant bats.
<ce> only animals.

QuestorPostfailure: [1009]
<ce> You couldn't even take care of giant
<ce> bats. You are hopeless %pcn.
<ce> rodents. You are hopeless %pcn.

-- messages 1002 to 1009 assumed it was bats, even when it
-- could be rats. now is ambiguous term instead.

QuestLogEntry: [1010]
%qdt:
Expand Down
6 changes: 5 additions & 1 deletion Assets/StreamingAssets/Quests/M0B00Y16.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,4 +254,8 @@ _giantWaveWhileInDungeon_ task:
pc at _mondung_ set _spawnGiants_

_spawnGiants_ task:
create foe _giantFriends_ every 3 minutes 6 times with 50% success
create foe _giantFriends_ every 15 minutes 6 times with 50% success

-- slowed spawn rate. this is a rank 0 quest, and I recognize that this is only after
-- the giant has been injured, but the previous setup risked
-- a new player getting surrounded by overwhelming spawns in the middle of combat.
10 changes: 7 additions & 3 deletions Assets/StreamingAssets/Quests/M0B1XY01.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ QuestorOffer: [1000]
<ce> of flyin' carnivores -- harpies -- who
<ce> are making a bunch of travelling merchants
<ce> real nervous. Will _reward_ gold get you
<ce> over to ___mondung_ and a
<ce> over to ___mondung_ for a
<ce> little hackin' 'n slashin'?

RefuseQuest: [1001]
Expand Down Expand Up @@ -136,8 +136,12 @@ _qgclicked_ task:
_1stparton_ task:
end quest

_S.04_ task:
create foe _monster_ every 15 minutes 20 times with 50% success
variable _S.04_
_spawnmonster_ task:
when _S.04_ and not _mondead_
create foe _monster_ every 45 minutes 15 times with 25% success
-- this spawn rate was accelerated in 2017, player feedback says it's rather unfair.
-- players need time to heal for several hours amid enemy spawns.

_clearclick_ task:
when _qgclicked_ and not _mondead_
Expand Down
14 changes: 10 additions & 4 deletions Assets/StreamingAssets/Quests/M0B20Y02.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ QuestFail: [1003]

QuestComplete: [1004]
<ce> %oth, them giants didn't know
<ce> what him 'em, did they, %pcf?
<ce> what hit 'em, did they, %pcf?
<ce> Here's your _reward_ gold, as promised.

RumorsDuringQuest: [1005]
Expand All @@ -61,7 +61,7 @@ QuestorPostsuccess: [1008]
<ce> %pcf. You'll go far in the guild.

QuestorPostfailure: [1009]
<ce> Giants were too much for you huh?
<ce> Giants were too much for you, huh?
<ce> Maybe the guild should have sent
<ce> you out after pygmies instead.

Expand Down Expand Up @@ -132,8 +132,14 @@ _pcgetsgold_ task:
give pc _reward_
end quest

_S.01_ task:
create foe _monster_ every 15 minutes 15 times with 50% success
variable _S.01_
-- added the new variable below to ensure monsters stop spawning when you've killed six, as the game says.

_spawnmonster_ task:
when _S.01_ and not _mondead_
create foe _monster_ every 45 minutes 15 times with 25% success
-- this spawn rate was accelerated in 2017, player feedback says it's rather unfair.
-- players need time to heal for several hours amid enemy spawns.

_mondead_ task:
killed 6 _monster_
Expand Down
2 changes: 1 addition & 1 deletion Assets/StreamingAssets/Quests/M0B21Y19.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Message: 1051
<ce> It's a trap!

Message: 1052
<ce> Thank you from rescuing me from
<ce> Thank you for rescuing me from
<ce> those assassins. If you could
<ce> get me to _safehouse_ in
<ce> __safehouse_, I can make my
Expand Down
4 changes: 2 additions & 2 deletions Assets/StreamingAssets/Quests/M0B30Y08.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ QuestorOffer: [1000]
RefuseQuest: [1001]
<ce> Too bad. Normally only the temples get
<ce> jobs like this. You've passed up a good
<ce> one %pcn.
<ce> one, %pcn.

AcceptQuest: [1002]
<ce> Her husband is a zombie. He hides out
Expand Down Expand Up @@ -53,7 +53,7 @@ RumorsPostsuccess: [1007]
<ce> They're a good lot, the guild.

QuestorPostsuccess: [1008]
<ce> You did well with that zombie %pcn.
<ce> You did well with that zombie, %pcn.

QuestorPostfailure: [1009]
<ce> The zombie was too much, huh? Shouldn't
Expand Down
8 changes: 4 additions & 4 deletions Assets/StreamingAssets/Quests/M0B40Y05.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ QuestorOffer: [1000]
<ce> Seems the monster is attacking
<ce> them when they are out in the
<ce> woods logging. Want to take a
<ce> hack at it %pcn?
<ce> hack at it, %pcn?

RefuseQuest: [1001]
<ce> Fair enough. Run along. I've
Expand Down Expand Up @@ -106,17 +106,17 @@ Message: 1022

Message: 1023
<ce> So the tree creature wants to cut
<ce> a deal, eh? Well I suppose I can
<ce> a deal, eh? Well, I suppose I can
<ce> convince the boys to only log the
<ce> big trees. But if his kind attack
<ce> big trees. But if its kind attack
<ce> us again, we'll burn every sapling
<ce> we can find! You've got yourself a
<ce> deal, %pcn.

Message: 1025
<ce> You worked it so the woodsmen and
<ce> the spriggan ain't fightin'? Very
<ce> clever %pcn. You'll go far if you
<ce> clever, %pcn. You'll go far if you
<ce> keep those wits sharp.

Message: 1030
Expand Down
2 changes: 1 addition & 1 deletion Assets/StreamingAssets/Quests/M0B50Y09.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ RumorsPostsuccess: [1007]
<ce> Those guys are good to have around.

QuestorPostsuccess: [1008]
<ce> Well done with the gargoyle %pcn.
<ce> Well done with the gargoyle, %pcn.

QuestorPostfailure: [1009]
<ce> That gargoyle killed the merchant.
Expand Down
6 changes: 3 additions & 3 deletions Assets/StreamingAssets/Quests/M0B60Y10.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ RefuseQuest: [1001]
<ce> jobs, like hunting rats.

AcceptQuest: [1002]
<ce> A young dandy what I have sworn to
<ce> keep unnamed, was screwing around
<ce> A young dandy that I have sworn to
<ce> keep unnamed was screwing around
<ce> with magic, illegally. Like a melonhead,
<ce> he up and conjures an atronach. The
<ce> he up and conjured an atronach. The
<ce> thing's gotta be destroyed before those
<ce> Mages Guild blokes find out. The thing
<ce> fled into the depths of ___dungeon_.
Expand Down
4 changes: 2 additions & 2 deletions Assets/StreamingAssets/Quests/M0C00Y11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ QRC:
QuestorOffer: [1000]
<ce> You can call me _qgiver_.
<ce> Normally we only give jobs to guild members.
<ce> But you show promise %pcn. I tell ya what.
<ce> But you show promise, %pcn. I tell ya what.
<ce> I got a request to dispose of a giant
<ce> scorpion. Do that and I'll see if the guild
<ce> will overlook your reputation. Is that a deal?
Expand All @@ -25,7 +25,7 @@ RefuseQuest: [1001]
<ce> outta here.

AcceptQuest: [1002]
<ce> You got guts %pcf, I'll give ya that.
<ce> You've got guts, %pcf, I'll give ya that.
<ce> Apparently this scorpion escaped from someone's
<ce> personal collection. Right now it's cornered in
<ce> _house_. Kill the thing today and
Expand Down
4 changes: 2 additions & 2 deletions Assets/StreamingAssets/Quests/M0C00Y12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ QuestorOffer: [1000]
<ce> it for a silkworm cocoon. The poor slob can't
<ce> afford to pay us to get rid of it. However,
<ce> if you take care of it for free the guild
<ce> looks good and I'll make sure you look good.
<ce> will look good and I'll make sure you look good.
<ce> Are you interested?

RefuseQuest: [1001]
Expand All @@ -34,7 +34,7 @@ AcceptQuest: [1002]
<ce> I'll put in a good word for you.

QuestComplete: [1004]
<ce> You got spunk %pcf.
<ce> You've got spunk, %pcf.
<ce> Keep up the good work and
<ce> you'll be Fighters Guild
<ce> material yet.
Expand Down
6 changes: 3 additions & 3 deletions Assets/StreamingAssets/Quests/M0C00Y13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ QuestorOffer: [1000]
<ce> The Fighters Guild doesn't hand out
<ce> charity work. If I weren't short on
<ce> fighters right now, I'd have to send
<ce> you away %pcn. I do need a fighter to
<ce> you away, %pcn. I do need a fighter to
<ce> chase off some barbarian that's
<ce> running wild. Do it for me and I'll
<ce> make sure everyone knows you're
<ce> a stand up %ra. Is it a deal?

RefuseQuest: [1001]
<ce> You've just made a big mistake
<ce> You've just made a big mistake,
<ce> %pcn. Don't come looking for
<ce> work here for a while.

Expand Down Expand Up @@ -51,7 +51,7 @@ RumorsPostsuccess: [1007]
<ce> the barbarian?

QuestorPostsuccess: [1008]
<ce> You managed that barbarian pretty well
<ce> You managed that barbarian pretty well,
<ce> %pcf. Not bad at all.

QuestorPostfailure: [1009]
Expand Down
Loading