Skip to content

Apparent typos in BidRequest examples #128

Description

@ljmcg

There appear to be two or possibly three typo/errors in the examples given in https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md

I do not know if these are intentional or if they are mistaken, but I wanted to point them out to anyone who knows better:

In [6.2.1 - Example 1 – Simple Banner] the text shows shows a user object nested inside the Site type ( https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#simplebanner )

In [6.2.4 Example 4 – Video] the text shows the Video object with a property called "apis" ( https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#624-example-4--video- ). The spec for VIdeo has a property called "api" (no final s). (https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#327---object-video-)

In [6.2.2 - Example 2 – Expandable Creative] the final user.data element has a "value" property, which is not documented for the Data object ( https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#622---example-2--expandable-creative- ) https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#objectdata

I want to be sure these are not intentional. It's conceivable that the Data object -should- include a "value" property in the documentation, for example.

If these are documentation errors in the examples, I would be happy to create a PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions