Repository navigation
Conversation
Member
|
Can you actually explain the changes here? |
Author
|
as part of shadow 9.6, we need to specify dsl receivers explicitly https://github.com/GradleUp/shadow/releases/tag/9.6.0 |
Member
|
But WorldEdit was able to resolve that more cleanly from a quick look? |
Move relocation configuration onto the ShadowJar receiver and keep dependency selection inside the nested dependency filter, matching the structure used by upstream WorldEdit. Signed-off-by: Suraj Rajan <surajkrajan95@gmail.com>
Author
|
Oh. Thanks for pointing out - using it as reference. |
renovate
Bot
force-pushed
the
renovate/shadow
branch
from
September 7, 2026 18:31
cc294ab to
808bfb3
Compare
renovate
Bot
force-pushed
the
renovate/shadow
branch
from
September 15, 2026 12:50
808bfb3 to
097d99a
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The receiver-scope fixes preserve existing packaging behavior and align with Shadow 9.6’s Kotlin DSL requirements.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Shadow to 9.6.1 and adapts active build scripts to its stricter Kotlin DSL receiver boundaries.
Changes:
- Moves relocations onto
ShadowJarreceivers. - Captures project/task values before nested DSL blocks.
- Preserves existing dependency filters and FAWE relocations.
| File | Description |
|---|---|
gradle/libs.versions.toml |
Upgrades Shadow to 9.6.1. |
build-logic/src/main/kotlin/buildlogic.platform.gradle.kts |
Captures the platform name outside the dependency receiver. |
worldedit-bukkit/build.gradle.kts |
Restructures relocations, dependency selections, and captured values. |
worldedit-cli/build.gradle.kts |
Moves relocations outside dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
renovate
Bot
force-pushed
the
renovate/shadow
branch
2 times, most recently
from
October 9, 2026 13:53
25621f7 to
3c1e6c5
Compare
renovate
Bot
force-pushed
the
renovate/shadow
branch
from
October 13, 2026 18:06
3c1e6c5 to
3d5bbe5
Compare
renovate
Bot
force-pushed
the
renovate/shadow
branch
from
October 26, 2026 22:33
3d5bbe5 to
a600630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShadowJarreceiver, following the structure used by WorldEdit #3010dependencies {}blockThis is a companion fix for #3625 and targets its Renovate branch.
Verification
0807ab860dca4ace921f748c535af02338ef95d0, JDK 25:./gradlew --no-daemon --max-workers=2 :build-logic:compileKotlin projects :worldedit-cli:shadowJar :worldedit-core:test :worldedit-bukkit:test :worldedit-cli:test— passed; core and Bukkit tests executed, while CLI has no test sourcesgit diff --check— passed:worldedit-bukkit:shadowJarwas attempted with Gradle launched on JDK 25 and JDK 21; the configured Java 25 toolchain stopped both runs during Paperweight adapter preparation, before Shadow packaging, because Codebook 1.0.14 rejects class-file version 69AI assistance
This change used JAIPilot skills:
jaipilot-maintainer-intentjaipilot-fast-executionjaipilot-review-diffHost model:
gpt-5.6-solReasoning effort:
xhighService mode:
fastExecution mode: local