COMP: Upgrade bit-rotted macOS runner pins to macos-14 house canonical#447
Open
hjmjohnson wants to merge 2 commits intomainfrom
Open
COMP: Upgrade bit-rotted macOS runner pins to macos-14 house canonical#447hjmjohnson wants to merge 2 commits intomainfrom
hjmjohnson wants to merge 2 commits intomainfrom
Conversation
The `build-test-cxx` job (and its paired `matrix.os == 'macos-*'` XCode-select conditional) and the `build-test-notebooks` job in .github/workflows/build-test-publish.yml pinned `macos-13`, which is now a deprecated GitHub Actions runner image. The `build-test-python-superbuild` job already targets `macos-15`, so it is intentionally left alone (the "do not downgrade" rule wins over strict convergence on the house canonical). Update the two `macos-13` entries -- matrix lines and include: blocks, plus the matching `matrix.os == 'macos-13'` conditional that selects the pinned Xcode 14.3.1 -- to `macos-14`. This matches the canonical runner triple `[ubuntu-24.04, windows-2022, macos-14]` used by the other ITK remote modules (VkFFTBackend, WebAssemblyInterface, ...) and keeps the Xcode pinning step wired up (Xcode 14.3.1 is still shipped in the `macos-14` image). The `build-test-documentation` job is ubuntu-only and is not touched. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
type:Compiler
Member
|
|
The macos-14 runner no longer has Xcode 14.3.1 installed. Instead
of hardcoding a specific Xcode version, detect the latest installed
Xcode app dynamically. This approach works across runner updates
without needing to track which Xcode versions are pre-installed.
xcode-select: error: invalid developer directory
'/Applications/Xcode_14.3.1.app'
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two of the three
build-test-*matrix blocks in.github/workflows/build-test-publish.ymlpinned the retiredmacos-13runner image. Upgrade them (and their pairedinclude:entries and thematrix.os == 'macos-13'Xcode-select conditional) tomacos-14, matching the canonical runner triple[ubuntu-24.04, windows-2022, macos-14]used by other ITK remote modules (VkFFTBackend, WebAssemblyInterface, ...).The
build-test-python-superbuildjob is intentionally left atmacos-15— the "never downgrade" rule wins over strict convergence on the house canonical.The ubuntu-only
build-test-documentationjob is not touched.Test plan
build-test-cxxruns cleanly onmacos-14(the Xcode 14.3.1 pinning step is still wired up — Xcode 14.3.1 ships in the macos-14 image).build-test-notebookspasses onmacos-14.build-test-python-superbuildjob onmacos-15is unchanged by this PR.