Skip to content

[IC-1099] fix(baseapp): log runTx panics with DEBUG level instead of Error since it is a user error#93

Merged
maxim-inj merged 1 commit into
v0.50.x-injfrom
IC-1099/log-run-tx-panics-as-debug-level
Jun 23, 2026
Merged

[IC-1099] fix(baseapp): log runTx panics with DEBUG level instead of Error since it is a user error#93
maxim-inj merged 1 commit into
v0.50.x-injfrom
IC-1099/log-run-tx-panics-as-debug-level

Conversation

@kakysha

@kakysha kakysha commented Jun 18, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

Chores

  • Adjusted logging level for panic recovery diagnostics.

@linear

linear Bot commented Jun 18, 2026

Copy link
Copy Markdown

IC-1099

@github-actions

Copy link
Copy Markdown

@kakysha your pull request is missing a changelog!

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

In BaseApp.runTxWithMultiStore, the deferred panic recovery block's logging call is changed from ctx.Logger().Error to ctx.Logger().Debug for the recovered panic error. No other logic, control flow, or error handling is modified.

Changes

Panic Recovery Log Level

Layer / File(s) Summary
Panic recovery log level change
baseapp/baseapp.go
The recovered panic error in the deferred recovery block is now logged at Debug level instead of Error level.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A panic once shouted with an error's red glare,
Now whispers in debug — just a soft-footed hare.
The logs grow more quiet, the noise fades away,
One level below where the loud errors stay.
🐇 Hop softly, dear panic, no need to shout today!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: modifying the log level for runTx panics from ERROR to DEBUG because they represent user errors, which directly aligns with the code change in baseapp.go.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch IC-1099/log-run-tx-panics-as-debug-level

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@baseapp/baseapp.go`:
- Line 918: Review the panic logging levels across all ABCI operation
handlers—specifically runTx, PrepareProposal, ProcessProposal, ExtendVote, and
VerifyVoteExtension—and make a deliberate choice: either align all of them to
use the same log level (DEBUG or ERROR) for consistency in observability across
similar failure scenarios, or add clear code comments explaining the intentional
distinction between runTx and the other ABCI handlers if the difference is
justified.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f887cfbd-4523-4261-ace5-607561802700

📥 Commits

Reviewing files that changed from the base of the PR and between 3361bee and 3807a37.

📒 Files selected for processing (1)
  • baseapp/baseapp.go

Comment thread baseapp/baseapp.go
@maxim-inj maxim-inj changed the title fix(baseapp): log runTx panics with DEBUG level instead of Error since it is a user error [IC-1099] fix(baseapp): log runTx panics with DEBUG level instead of Error since it is a user error Jun 23, 2026
@maxim-inj maxim-inj merged commit 208c5cb into v0.50.x-inj Jun 23, 2026
41 of 51 checks passed
@maxim-inj maxim-inj deleted the IC-1099/log-run-tx-panics-as-debug-level branch June 23, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants