[IC-1099] fix(baseapp): log runTx panics with DEBUG level instead of Error since it is a user error#93
Conversation
since it is a user error
|
@kakysha your pull request is missing a changelog! |
📝 WalkthroughWalkthroughIn ChangesPanic Recovery Log Level
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@baseapp/baseapp.go`:
- Line 918: Review the panic logging levels across all ABCI operation
handlers—specifically runTx, PrepareProposal, ProcessProposal, ExtendVote, and
VerifyVoteExtension—and make a deliberate choice: either align all of them to
use the same log level (DEBUG or ERROR) for consistency in observability across
similar failure scenarios, or add clear code comments explaining the intentional
distinction between runTx and the other ABCI handlers if the difference is
justified.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Summary by CodeRabbit
Chores