Add mm operator support - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
aten::mmfor two-dimensional, same-devicefloat32Infini tensors by calling InfiniOps Gemm implementation index 0 on the current stream.The initial path supports contiguous inputs, transposed non-overlapping dense weights, empty dimensions, and input/output storage lifetime tracking. It intentionally rejects unsupported dtypes, devices, ranks, and overlapping layouts instead of falling back through CPU.
This enables
torch.nn.Linear(..., bias=False)inference through PyTorch's existing transpose-and-mm path. Bias,mm.out, training, backward, and propagation oftorch.set_float32_matmul_precision("highest")remain outside this PR.This PR is stacked on #37, which is stacked on #36. The intended merge order is #36, #37, and then this PR.
Testing
95c70080f9551e61241110497d163dfcdf9dc7e7, and InfiniOps commit296271487beb594a248fd463e5fff14f7ab74293.torch.cuda.mmunder PyTorch 2.13's defaulthighfloat32 matrix-multiplication precision.torch.nn.Linearmodule after moving its weight and input to theinfinidevice.