Preserve dense add output layouts - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves the left operand layout for Add results when the output shape is unchanged and the operand is non-overlapping and dense.
It uses the public empty_like API with MemoryFormat::Preserve for that case and retains contiguous allocation for broadcasting, expanded inputs, and gapped layouts.
It extends the CPU-oracle test helper to copy raw noncontiguous result storage, converts the transposed-output strict expected failure into a passing conformance case, and adds an expanded-stride regression.
This advances the Add semantics work in #13.
Validation