Skip to content

Fix portable fast-path predicates#198

Open
voltjia wants to merge 1 commit into
masterfrom
fix-portable-fast-path-predicate
Open

Fix portable fast-path predicates#198
voltjia wants to merge 1 commit into
masterfrom
fix-portable-fast-path-predicate

Conversation

@voltjia

@voltjia voltjia commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Render Python-backend contiguous fast-path conjunctions as nested binary boolean operations.
  • Preserve the existing CUDA C-style conjunction output.
  • Cover Triton, TileLang, and CUDA source structure with one regression test.

Root cause: the shared SSA emitter produced one three-value Python BoolOp; Triton 3.1 and 3.3 accept only binary boolean operations in this path.

pytest output:

NVIDIA (accelerator-dev/nvidia:latest), affected suites:
Running 31 items in this shard
...............................                                          [100%]
31 passed in 6.47s

NVIDIA, exact renamed selector:
Running 1 items in this shard
.                                                                        [100%]
1 passed in 1.12s

Iluvatar (image e8382905ffaa), regression plus add integration:
..                                                                       [100%]
2 passed in 2.69s

Hygon (sglang-deepseek-v4-dev-zkjh), master reproduction:
FAILED tests/test_add.py::test[98432-dtype0-cuda]
UnsupportedLanguageConstruct: chained boolean operators are not supported
1 failed in 14.39s

Hygon, exact head 2d720193, affected suites:
.............................                                            [100%]
29 passed in 16.74s

@voltjia
voltjia marked this pull request as ready for review July 22, 2026 05:37
@voltjia
voltjia force-pushed the fix-portable-fast-path-predicate branch from 2d72019 to ba1059c Compare July 24, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant