feat!: return flash attention varlen auxiliary outputs - #854
Open
voltjia wants to merge 1 commit into
Open
Conversation
voltjia
force-pushed
the
feat/align-flash-attn-varlen-returns
branch
from
July 29, 2026 09:51
b353df7 to
b8055ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flash_attn_varlen_func(..., out)overload unchanged and out-only.softmax_lseands_dmaskoutputs.return_attn_probs=true, and populate them in the NVIDIA Torch implementation.Motivation
return_attn_probswas already public, but the full interface omitted FlashAttention's corresponding auxiliary outputs. The basic overload should continue to model the default out-only call.API Alignment
flash_attn_varlen_func(..., out)outflash_attn_varlen_func(..., return_attn_probs, ..., out, softmax_lse?, s_dmask?)(out, softmax_lse, S_dmask)only whenreturn_attn_probs=TrueType of Change
featfixperfrefactortestdocsbuild/cichorePlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A.
Notes for Reviewers
The basic overload remains out-only. The full overload uses
std::optional<Tensor>only for the conditional auxiliary outputs.This PR is based directly on
master. It contains no Moore files and has no dependency on #819; a future Moore implementation can adapt to the public interface independently.