feat: align elu with PyTorch Python API#811
Merged
Merged
Conversation
voltjia
force-pushed
the
feat/align-elu-python-api
branch
from
July 24, 2026 08:02
a5603ce to
bb7ed2f
Compare
voltjia
force-pushed
the
feat/align-elu-python-api
branch
from
July 24, 2026 08:27
bb7ed2f to
e4cd313
Compare
voltjia
force-pushed
the
feat/align-elu-python-api
branch
from
July 24, 2026 11:07
e4cd313 to
b7e2bf0
Compare
elu with PyTorch Python API
voltjia
marked this pull request as ready for review
July 27, 2026 01:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elu(input, alpha, out)interface matching PyTorch's public attribute.scaleandinput_scaleinterface as a[[deprecated]]compatibility overload.Motivation
The public InfiniOps ELU interface exposed internal ATen implementation parameters that do not appear in
torch.nn.functional.elu. The earlier revision also added analpha=1.0convenience overload; this revision removes it to keep the overload set minimal.No standalone issue is associated with this alignment follow-up.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. The primary interface delegates to the existing ATen implementation with
scale=1.0andinput_scale=1.0.Notes for Reviewers
API alignment
elu(input, alpha, out)outremains last perCONTRIBUTING.md.F.elu(input, alpha=1.0, inplace=False)elu(input, alpha, scale, input_scale, out)alpha=1.0explicitly when they want the PyTorch default.test_oppath was extended instead of adding another test function.