fix(typedoc): Fix merge properties from base classes and remove obsolete base class name rosolving.#175
Open
skrustev wants to merge 2 commits into
Open
fix(typedoc): Fix merge properties from base classes and remove obsolete base class name rosolving.#175skrustev wants to merge 2 commits into
skrustev wants to merge 2 commits into
Conversation
…ete base class name rosolving.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the custom TypeDoc plugin logic used to surface component/base-class members in the generated React component API docs, addressing incorrect/obsolete base type handling (per api-docs issue #140).
Changes:
- Expands the set of excluded base types and adds an excluded-property list.
- Refactors base-type property traversal to handle intersections/merged base types via
resolveBaseTypeProps. - Removes the older
extractBaseTypelogic that previously populatedextendedTypes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+186
to
+189
| if ( | ||
| type.symbol?.name.includes('EventEmitterInterface') || | ||
| excludeBaseTypes.includes(type.symbol?.name) | ||
| ) { |
Comment on lines
+244
to
+246
| if (!type.baseTypesResolved || type.resolvedBaseTypes?.length === 0) { | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/IgniteUI/api-docs/issues/140
Additional information (check all that apply):
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionality