Skip to content

catch potential error in ImageBuilderResource.php - #97

Open
Myrmod wants to merge 1 commit into
IchHabRecht:mainfrom
Myrmod:patch-1
Open

catch potential error in ImageBuilderResource.php#97
Myrmod wants to merge 1 commit into
IchHabRecht:mainfrom
Myrmod:patch-1

Conversation

@Myrmod

@Myrmod Myrmod commented Jan 29, 2026

Copy link
Copy Markdown

Just a small fix for catching a potential error that happens locally. Shouldn't break anything

@dkd-kaehm

Copy link
Copy Markdown

Please merge.

It fixes the issue file_exists(): Argument #1 ($filename) must be of type string, null given
Since $theImage var is nullable.

$theImage = $gifBuilder->gifBuild()?->getFullPath();
if (file_exists($theImage)) {

@IchHabRecht

Copy link
Copy Markdown
Owner

would you mind to give me a hint how the error you're seeing can be reproduced? hope you understand that I cannot merge any changes before evaluating and understanding the circumstances.

@Myrmod

Myrmod commented May 5, 2026

Copy link
Copy Markdown
Author

would you mind to give me a hint how the error you're seeing can be reproduced? hope you understand that I cannot merge any changes before evaluating and understanding the circumstances.

If I remember correctly solr stored some image data and the stored images were breaking things in combination with filefill.

I might be confusing something though. Cannot look at the code properly at the moment and it's a while ago.

Either way the change cannot negatively impact the functionality of the extension I believe. It is save to merge.
However it is obviously your choice.
I'll see if I can find the exact cause of the error for me tomorrow, in case I have time in between work. :)

@dkd-kaehm

dkd-kaehm commented May 6, 2026

Copy link
Copy Markdown

If I remember correctly solr stored some...

👺 Hehe just because I can reproduce it doesn’t automatically mean Solr is involved.

@Myrmod

Myrmod commented May 6, 2026

Copy link
Copy Markdown
Author

If I remember correctly solr stored some...

👺 Hehe just because I can reproduce it doesn’t automatically mean Solr is involved.

Hahaha, not what I meant. I remember darkly that I had an issue where something didn't work because someone stored image references in solr and the template couldn't find those files anymore ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants