Conversation
|
This is exciting! looking forward to reviewing it in the next day or two! |
|
pushing this to test now - is it possible to test locally? getting domain errors trying it on my setup |
|
Test build will likely fail due to migration conflict. Fixed it just now in this branch. More migration conflicts will come, the translation PR have a lot migrations e.g. If we push this to test and then do not merge this in before translate PR we will have to reset the test db a bit. |
Yes, if you set base_url to "localhost". Then it will not require TLS either. IP 127.0.0.1, hypha.test etc. will not work due to how browsers handle this for security. This should work:
|
|
left a super minor comment but otherwise this is totally ready to go! |
|
@wes-otf Good change. Looking at it I came up with some more ways to polish it. The green check is there but when you start typing in the name field the check turns blu with a border so it looks like a button. Clicking it saves and makes it green without a border again. |
|
Added some new stuff:
|
…to set passkey name.
Co-authored-by: Wes Appler <145372368+wes-otf@users.noreply.github.com>
…button and turn green on save.
…idden inputs to data attributes. Handle os errors nicer, like when trying to add a second icloud key.
Fixes #4563
This implementation uses duo-labs/py_webauthn: Pythonic WebAuthn directly implementing its own Django wrapper. This is so passkeys are used as a stand alone login method and not as a 2FA option.
The interesting parts are in
passkey_views.pyandpasskeys.js.Test Steps