Skip to content

SCENARIO: Concurrent editors of the same document should be aware of which blocs are being edited (see #251).#417

Merged
benel merged 4 commits into
mainfrom
fix-251
Jun 14, 2026
Merged

SCENARIO: Concurrent editors of the same document should be aware of which blocs are being edited (see #251).#417
benel merged 4 commits into
mainfrom
fix-251

Conversation

@Dinalrn

@Dinalrn Dinalrn commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Co-authored-by:
Magdalena KHIAT magdalena.khiat@utt.fr
Dina LOUARN dina.louarn@utt.fr
Emeline NEROT emeline.nerot@utt.fr
Nathan NICART nathan.nicart@utt.fr

We, Magdalena KHIAT, Dina LOUARN, Emeline NEROT, Nathan NICART, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Comment thread frontend/tests/event.js Outdated

Quand("{string} est en train d’éditer le passage {string}", (username, passageNumber) => {
cy.request_by_user(username,{beingEditedBy: username});
cy.get('.scholium .formatted-text').click();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that one of your problem with tests is because of this line. You make Alice edit the passage, whereas only Bill should.
I will try without this line.

@benel benel force-pushed the fix-251 branch 2 times, most recently from 58b6863 to cd0a6f9 Compare June 14, 2026 17:37
Dinalrn and others added 4 commits June 14, 2026 19:45
…which blocs are being edited (see #251).

Co-authored-by: Nathan Nicart <nathan.nicart@utt.fr>
Co-authored-by: Emeline Nerot <emeline.nerot@utt.fr>
…h blocs are being edited (see #251).

Co-authored-by: Nathan Nicart  <nathan.nicart@utt.fr>
…of which blocs are being edited (fixes #251).

Implemented first as Long Polling and then changed with EventSource.

Co-authored-by: Nathan Nicart <nathan.nicart@utt.fr>
Co-authored-by: Emeline Nerot <emeline.nerot@utt.fr>
@benel benel merged commit 457fcfa into main Jun 14, 2026
3 checks passed
@benel benel deleted the fix-251 branch June 14, 2026 18:05
@benel

benel commented Jun 14, 2026

Copy link
Copy Markdown
Member

Thank you very much for your contribution @Hypertopic/ethnographie.
Your contribution is now live on the production server! Well done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concurrent editors of the same document should be aware of which blocs are being edited

5 participants