Skip to content

chore: remove internal handoff doc; ignore .playwright-mcp - #5800

Merged
Hmbown merged 1 commit into
mainfrom
chore/public-repo-hygiene-20260901
Sep 1, 2026
Merged

chore: remove internal handoff doc; ignore .playwright-mcp#5800
Hmbown merged 1 commit into
mainfrom
chore/public-repo-hygiene-20260901

Conversation

@Hmbown

@Hmbown Hmbown commented Sep 1, 2026

Copy link
Copy Markdown
Owner

GROK_TUI_SETTINGS_HANDOFF.md slipped in with #5655 (71253d5656): an agent-session handoff naming local worktree paths and lane strategy, referenced nowhere in the repo. Content preserved in the private ops repo as HANDOFF-GROK-TUI-SETTINGS-20260829.md; removed here.

.playwright-mcp/ is untracked local output that was one careless git add . from publication — now gitignored.

No code change.


Note

Low Risk
Documentation and ignore-list only; no runtime or application code changes.

Overview
Removes GROK_TUI_SETTINGS_HANDOFF.md, an internal agent-session handoff (worktree paths, lane strategy) that was committed by mistake; durable copy lives in private ops.

Adds .playwright-mcp/ to .gitignore so local Playwright MCP output stays untracked and doesn’t get published via a broad git add.

Reviewed by Cursor Bugbot for commit bd9cbfe. Bugbot is set up for automated code reviews on this repo. Configure here.

GROK_TUI_SETTINGS_HANDOFF.md slipped in with #5655 (71253d5): an
agent-session handoff naming local worktree paths and lane strategy,
referenced nowhere. Preserved in the private ops repo as
HANDOFF-GROK-TUI-SETTINGS-20260829.md; removed here.

.playwright-mcp/ is untracked local output that was one careless
'git add .' from publication.

Signed-off-by: CodeWhale Bot <bot@codewhale.net>
Copilot AI lite review requested due to automatic review settings September 1, 2026 20:55
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@cursor

cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2c169c1e-5b95-4db1-a702-e0e4daa7a5b9)

@claude

claude Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Hmbown's task in 33s —— View job


Review complete ✅

  • Gather context (PR diff, changed files)
  • Review .gitignore change
  • Review removal of GROK_TUI_SETTINGS_HANDOFF.md
  • Check for provider/model route safety implications
  • Post final review

Summary

Clean, minimal hygiene PR — no code changes, matches its description exactly.

.gitignore (+3): adds .playwright-mcp/ alongside the existing .ralph/ local-scratch convention. Verified this directory isn't currently tracked (git ls-files has no matches), so there's nothing left to git rm — the ignore entry alone is sufficient.

GROK_TUI_SETTINGS_HANDOFF.md (deleted, -124): an agent-session handoff doc naming local worktree paths (/Volumes/VIXinSSD/...) that has no business being in a public repo. Confirmed no other file in the repo references this filename, so removal is safe and complete. Per PR description, content is preserved in the private ops repo.

Checks against review criteria

  • Correctness bugs: N/A — no code touched.
  • Provider/model/route safety (EPIC v0.8.65 EPIC: Separate provider facts, model facts, offerings, and route resolution #2608): N/A — no routing/provider code touched. (Worth noting: the deleted doc's own content correctly avoided inventing a hy4 model id and was careful about provider-prefix vs. actual provider selection — a good example of the invariant this repo cares about, now safely relocated to the private ops repo instead of living in public history.)
  • Reuse/simplification: N/A.
  • Tests: N/A — doc-only change, no test coverage needed.
  • Security: Net positive — removes a doc with local absolute paths and lane-strategy detail from public history, and closes off a plausible git add . leak vector for local Playwright MCP output.

No issues found. LGTM.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved: Cursor Bugbot was present but skipped (usage limit), so the required automated-review signal did not complete successfully. Human review is needed; one reviewer was assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to deleting an unreferenced internal doc and adding a narrowly scoped ignore rule with no runtime impact.

Pull request overview

Removes an accidentally committed internal handoff document (containing local worktree/lane details) and adds a gitignore rule to prevent local Playwright MCP artifacts from being published.

Changes:

  • Delete GROK_TUI_SETTINGS_HANDOFF.md (no in-repo references found).
  • Add .playwright-mcp/ to .gitignore to keep local Playwright MCP output untracked.
File summaries
File Description
GROK_TUI_SETTINGS_HANDOFF.md Removes an internal-only handoff doc that was committed unintentionally.
.gitignore Ignores .playwright-mcp/ so local Playwright MCP artifacts aren’t accidentally committed.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codewhale-agent codewhale-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewhale review

Removes the accidentally committed GROK_TUI_SETTINGS_HANDOFF.md internal handoff document and adds .playwright-mcp/ to .gitignore. Documentation and ignore-list only; no runtime or application code changes.

Assessment

Safe documentation and ignore-list change. No code paths are affected, and no tests are required for this PR.


Advisory review by Codewhale (codewhale review --pr 5800 --post, head bd9cbfee5acaf7121e8bbd9d6fc034ecbc297d86). Line-specific findings are also posted as inline review comments; mechanical fixes arrive as committable suggestions you can apply from the Files tab. CODEOWNERS approval still governs merge.

@Hmbown
Hmbown merged commit bbd3e0e into main Sep 1, 2026
32 of 35 checks passed
@Hmbown
Hmbown deleted the chore/public-repo-hygiene-20260901 branch September 1, 2026 21:34
Hmbown pushed a commit that referenced this pull request Sep 1, 2026
…5797, #5796, #5795, #5805, #5800)

Signed-off-by: CodeWhale Bot <bot@codewhale.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants