Repository navigation
feat[next]: Precompilation with static domains #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SF-N
wants to merge
18
commits into
GridTools:main
Choose a base branch
from
SF-N:static_domain_precompilation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dc6dbb7
Add static_domains for pre-compilation
SF-N c3e0453
Minor
SF-N 46a855e
Some fixes
SF-N 57db00a
Merge branch 'main' into static_domain_precompilation
SF-N 694d927
Refactor test and add error message
SF-N bf02bb8
Merge branch 'static_domain_precompilation' of github.com:SF-N/gt4py …
SF-N c2d0e9d
Formatting
SF-N 3b6c14d
Merge branch 'main' into static_domain_precompilation
SF-N 9bc34cd
Update static_domains type to support per-field domain specifications
SF-N bb49222
Merge remote-tracking branch 'origin/main' into static_domain_precomp…
tehrengruber 5a5adf5
Merge branch 'static_domain_precompilation' of github.com:SF-N/gt4py …
SF-N c8cf9fa
Merge remote-tracking branch 'origin/main' into pr-2483
tehrengruber 7838948
Merge branch 'main' into static_domain_precompilation
tehrengruber 7aa6391
Fix test_compile_variants_decorator_static_domains
SF-N e11f9fa
Merge branch 'static_domain_precompilation' of github.com:SF-N/gt4py …
SF-N 0efb85c
Merge remote-tracking branch 'origin/main' into pr-2483
tehrengruber d4ba166
Merge remote-tracking branch 'origin_sf_n/static_domain_precompilatio…
tehrengruber 76bd233
Merge remote-tracking branch 'origin/main' into pr-2483
tehrengruber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static_domainsis checked via truthiness (if static_domains:), so passing an empty dict (which is still a non-Nonevalue per the public API) will silently skip buildingFieldDomainDescriptors. This can lead to compiling a variant without any domain descriptors even though the caller explicitly providedstatic_domains. Consider switching this condition toif static_domains is not None:(and let_build_field_domain_descriptorsraise for missing dims as needed).