fix: exit 0 when a downstream reader closes stdout early#1811
Open
varuntej07 wants to merge 1 commit into
Open
fix: exit 0 when a downstream reader closes stdout early#1811varuntej07 wants to merge 1 commit into
varuntej07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Piping graphify into a reader that stops early (
head, PowerShellSelect-Object -First N, a pager that quits) closes stdout before we finishwriting. The interpreter's shutdown flush then hits the closed pipe and crashes:
The process exits nonzero (120 on POSIX). A downstream
headclosing the pipeis normal, so graphify should exit 0 the way
foo | headdoes.Fix
Wrap the CLI entry point: catch
BrokenPipeErrorandOSErrorwithEINVALorEPIPE(Windows reports a closed pipe asEINVAL), redirect stdout to devnullso the shutdown flush stays quiet, and exit 0. Unrelated
OSErrors stillpropagate, so real failures such as a missing
graph.jsonare not masked.Verification
A reader that reads one line then closes the pipe:
Adds
tests/test_broken_pipe_exit.py(5 tests covering the exit-code contract,including that non-pipe errors still propagate). Existing CLI suites pass.