Rewrite low storage dialog to Compose#166
Open
RankoR wants to merge 12 commits into
Open
Conversation
RankoR
changed the title
RankoR
requested review from
inthewaves,
m4pl and
soupslurpr
and removed request for
m4pl
inthewaves
suggested changes
Jun 27, 2026
Comment on lines
+64
to
+70
| LaunchedEffect(screenModel, onFinish) { | ||
| screenModel.effects.collect { effect -> | ||
| when (effect) { | ||
| Effect.Finish -> onFinish() | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We should use rememberUpdatedState for onFinish instead of using it as a LaunchedEffect key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.