Conversation List Screen: Java/XML to Kotlin/Compose migration by m4pl · Pull Request #162 · GrapheneOS/Messaging

m4pl · 2026-06-25T00:16:45Z

Migrated the Conversation List screen from Java + XML to Kotlin + Compose. Please verify the list animations (archive, undo, pin/unpin, scroll-to-top) manually on a device, as I had some issues after writing the code. I also tried to move some components to ui/common/components.

Screenshots

Before	After

Video

Screen_recording_20260625_015257.mp4

…ming

inthewaves · 2026-06-27T03:33:00Z

+import com.android.messaging.data.conversationlist.model.ConversationListMessageStatus
+
+@Immutable
+internal data class ConversationListItemUiModel(


If the last message was an incoming MMS message that hasn't been downloaded, not enough info is displayed to the user:

Google Messages for reference on the same message:

inthewaves · 2026-06-27T03:41:17Z

+    val description = when {
+        isArchive -> stringResource(R.string.action_archive)
+        else -> stringResource(R.string.mark_as_unread)
+    }


This seems like it'll use R.string.mark_as_unread for content description even if the swipe action is mark as read

inthewaves · 2026-06-27T03:42:34Z

+    private int upgradeToVersion3(final SQLiteDatabase db) {
+        db.execSQL("ALTER TABLE " + DatabaseHelper.CONVERSATIONS_TABLE + " ADD COLUMN " +
+                DatabaseHelper.ConversationColumns.PINNED + " INT DEFAULT(0)");
+        LogUtil.i(TAG, "Upgraded database to version 3");
+        return 3;
+    }


Seems to be missing the index creation

As a side note, we should probably eventually add tests to ensure a migrated database is the same as newly created database

inthewaves · 2026-06-27T04:05:02Z

+        enableEdgeToEdge()
+
+        setContent {
+            AppTheme {


The theme for ConversationListActivity in the manifest is still @style/LaunchTheme, maybe we should use Theme.Compose instead

inthewaves · 2026-06-27T04:10:42Z

+    var pendingAddContactDestination by rememberSaveable { mutableStateOf<String?>(null) }
+    var pendingDelete by rememberSaveable { mutableStateOf(false) }
+    var pendingBlockConversationId by rememberSaveable { mutableStateOf<String?>(null) }
+    var pendingBlockDestination by rememberSaveable { mutableStateOf<String?>(null) }
+    var pendingSnooze by rememberSaveable { mutableStateOf(false) }


These use rememberSaveable but they seem like they can be out of sync with the actual state in the ViewModel, e.g

Enable Android developer option "Don't keep activities", or otherwise force the app process/activity to be destroyed while in the background

Open Messaging, long-press a conversation, and tap the delete action so the confirmation dialog is visible.

Background the app, then return to Messaging from Recents.

Observe that the delete dialog can be restored even though the new view-model state no longer has the original selection. When only one conversation was selected for deletion, the dialog title can change from "Delete this conversation" to "Delete these conversations?" after the process death, and the delete button is a no-op.

Repeat with snooze, the dialog will be a no-op

It seems that for block or add contact from a row action, the restored dialog can still reference the old destination after the underlying list state has been recreated

It might be better to just make these remember

inthewaves · 2026-06-27T04:16:23Z

+
+@Composable
+internal fun ConversationListDialogs(
+    selectedCount: Int,


Maybe we should sanity check this against a selectedCount of 0. Dialogs are still shown when selectedCount is 0 it seems (e.g. the Don't keep activities enabled with Delete and Snooze dialogs)

inthewaves · 2026-06-27T04:17:09Z

+    if (isSnoozeVisible) {
+        SnoozeChatDialog(
+            onDismiss = onDismissSnooze,
+            onConfirm = { option ->
+                onAction(Action.SnoozeOptionSelected(option))
+                onDismissSnooze()
+            },
+        )
+    }


The snooze chat dialog should use plural strings when multiple chats are selected. The dialog currently says "Snooze chat" and "You won't get notifications from this chat for the selected period"

inthewaves · 2026-06-27T04:23:50Z

+    TwoLineListItem(
+        onClick = onClick,
+        leadingContent = {
+            ConversationListItemAvatar(
+                item = item,
+                isSelectionMode = isSelectionMode,
+                onToggleSelection = onClick,
+                onMessageClick = onAvatarMessageClick,
+                onCallClick = onAvatarCallClick,
+                onContactClick = onAvatarContactClick,
+                onInfoClick = onAvatarInfoClick,
+            )
+        },
+        titleContent = {
+            ConversationListItemHeader(item)
+        },
+        modifier = modifier.testTag(
+            tag = conversationListItemTestTag(item.conversationId),
+        ),
+        onLongClick = onLongClick,
+        color = itemContainerColor(item),
+        subtitleContent = {
+            ConversationListItemBody(item)
+        },
+        trailingContent = {
+            ConversationListItemTrailing(item)
+        },
+    )


This appears to regress a lot of the accessibility content descriptions compared to the old Messages code, e.g.

https://github.com/GrapheneOS/Messaging/blob/12/src/com/android/messaging/ui/conversationlist/ConversationListItemView.java#L304

https://github.com/GrapheneOS/Messaging/blob/12/res/values/strings.xml#L372-L389

When I use TalkBack with the old messages app, for successful messages, it will say stuff like

Message from <contact>, <message body>, time <time>

This is from

<string name="one_on_one_incoming_successful_message_prefix">Message from <xliff:g id="sender">%1$s</xliff:g>: <xliff:g id="message">%2$s</xliff:g>. Time: <xliff:g id="time">%3$s</xliff:g>.</string>

e.g.

Message from Bob, "Hello there". Time: 33 minutes

and it will not select the avatar. The only other things TalkBack will scroll over are attachments, e.g. for an audio attachment, it will say "Play audio attachment"

When I use TalkBack with this PR, it will just say,

Bob, 33 minutes, "Hello there"

and for the top conversation it might say "in list, 57 items"

Swiping on TalkBack to try to go to the next may select the avatar (when the contact doesn't have a custom avatar in contacts) and it'll just say "capital F" for a contact with first name F, or "unlabeled" for just a number or a group avatar

inthewaves · 2026-06-27T04:24:56Z

+@Composable
+private fun ConversationListItemBadgeIcon(icon: ImageVector) {
+    Icon(
+        imageVector = icon,
+        contentDescription = null,
+        modifier = Modifier.size(ItemBadgeIconSize),
+        tint = MaterialTheme.colorScheme.onSurfaceVariant,
+    )
+}


We should avoid null contentDescriptions and describe what the badge is indicating, or the accessibility hint on the conversation list item itself should mention the status instead of the badge icon being traversable

inthewaves · 2026-06-27T10:06:58Z

+    ) { contentPadding ->
+        Box(
+            modifier = Modifier
+                .fillMaxSize()
+                .padding(top = contentPadding.calculateTopPadding())
+                .onGloballyPositioned { coordinates ->
+                    pinAnimationController?.updateContentTop(coordinates.boundsInRoot().top)
+                }
+                .background(backdropColor)
+                .clip(ContentCornerShape)
+                .background(MaterialTheme.colorScheme.background),
+        ) {


Needs to be inset aware when using 3-button gesture navigation; the camera cutout can also clip into the sides especially in the other landscape orientation (camera hole not shown)

(The appbar itself seems to be inset aware)

inthewaves · 2026-06-27T10:09:11Z

+@Composable
+private fun ConversationListItemTrailing(item: ConversationListItemUiModel) {
+    Row(
+        modifier = Modifier.padding(end = ItemTrailingEndPadding),
+        horizontalArrangement = Arrangement.spacedBy(ItemHeaderSpacing),
+        verticalAlignment = Alignment.CenterVertically,
+    ) {
+        ConversationListItemPreviewThumbnail(item.snippet.preview)
+    }
+}


I think the thumbnail placement makes it look unaligned or not uniform, because it offsets the timestamp compared to other conversations that don't have the thumbnail

m4pl force-pushed the conversation-list-compose branch from bad5319 to d8c26b7 Compare June 25, 2026 23:53

m4pl added 29 commits June 26, 2026 12:36

Add common components ParticipantAvatar and TwoLineListItem

7ad81ed

Add conversation list data repository

4652ae4

Add conversation list redesign state and actions

6eaa175

Map conversation list message status in data layer

d893db7

Unify conversation archive, delete and block use cases

eb8f23d

Extract conversation list delegates

c70ccd3

Add conversation list item components

5f9c97e

Add conversation list screen scaffold

cff0758

Decouple debug options menu from FragmentActivity

e7a27c8

Switch conversation list to Compose

ff1ee9d

Migrate BlockedParticipantsDelegate to repository.setDestinationBlocked

d91c81e

Polish conversation list FABs, toolbar and corners

ddab8cf

Extract shared primary button and snackbar helpers

fa4982e

Move ConversationListItemAvatar to separate file

a194a3e

Add avatar quick actions to conversation list

6ca3e30

Add chat snooze and polish conversation list rows

001c9e2

Add swipe actions to conversation list rows

4842eba

Rework conversation list selection toolbar

4b2dfc3

Add pin conversation support to the conversation list

4ae6e40

Add tests for pin conversation support

7bf0380

Gate Compose activities behind permission check

9094594

Make conversation list animations smooth with optimistic state

f197e12

Polish conversation list statuses, avatar actions and snackbars

adc64b4

Remove conversation list redesign package nesting

693436e

Fix conversation list interactions and clean up supporting APIs

80627f4

Simplify conversation list selection and action state model

02daa41

Restore MMS subject cleansing and clarify conversation list mapper na…

b7e4fa1

…ming

Refactor conversation list optimistic updates and list animations

1bf12b8

Update optimistic conversation list reducer coverage

5ff7ae3

m4pl added 8 commits June 26, 2026 12:49

Cover conversation stores and permission gate

eee3603

Cover conversation list reorder behavior

a1add22

Cover conversation list delegate

7752d52

Cover conversation list state mapping and actions

8dee207

Lock conversation swipe to horizontal dominant gestures

271f70a

Stabilize conversation list appearance and insertion animations

da2613b

Tidy conversation list empty state and FABs

6668b9c

Fix compilation after rebase

b9681c6

m4pl force-pushed the conversation-list-compose branch from d8c26b7 to b9681c6 Compare June 26, 2026 10:56

m4pl requested review from RankoR and inthewaves and removed request for RankoR June 26, 2026 14:45

Share conversation list fixtures and update UI tests

000a06c

m4pl force-pushed the conversation-list-compose branch from a6b46ac to 000a06c Compare June 26, 2026 14:47

m4pl marked this pull request as ready for review June 26, 2026 15:05

inthewaves suggested changes Jun 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Conversation List Screen: Java/XML to Kotlin/Compose migration#162

Conversation List Screen: Java/XML to Kotlin/Compose migration#162
m4pl wants to merge 38 commits into
GrapheneOS:mainfrom
m4pl:conversation-list-compose

m4pl commented Jun 25, 2026 •

edited

Loading

Uh oh!

inthewaves Jun 27, 2026 •

edited

Loading

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

inthewaves Jun 27, 2026 •

edited

Loading

Uh oh!

inthewaves Jun 27, 2026 •

edited

Loading

Uh oh!

inthewaves Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

m4pl commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Video

Uh oh!

inthewaves Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inthewaves Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inthewaves Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

m4pl commented Jun 25, 2026 •

edited

Loading

inthewaves Jun 27, 2026 •

edited

Loading

inthewaves Jun 27, 2026 •

edited

Loading

inthewaves Jun 27, 2026 •

edited

Loading