Un-mock the Timesheet screen and wire it to the Timesheet API (GA-008) - #446
Merged
Conversation
Rana7xi
requested review from
Bhavya1534,
LoopyB,
TeddyScript101 and
chaitanyakotagiri27
July 30, 2026 13:42
Collaborator
|
The code is correct and I verified the backend contract fully matches (serializer fields, list {page,limit,total,timesheets}, both routes, guard-token scoping). It's also a cleaner, more complete implementation than the earlier timesheet work — proper endpoint, detail screen, totals, error/retry, i18n. The three notes I raised (pagination cap, formatHours decimals, UTC/local dates) are cosmetic follow-ups, not merge blockers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The Timesheet screen was reading from the attendance endpoint and working
out the hours on the phone, which ignored break time. It now loads from the
Timesheet API and shows the hours the backend already works out.
Changes
Testing
Tested on the Android emulator with two completed shifts, one normal day
shift and one that runs overnight across midnight. The hours on screen match
the API response. The detail view opens and the empty state works.
Type check, lint and format all pass.