Skip to content

fix: remove empy confusing trace/trace-python-sample directory#13995

Open
iennae wants to merge 1 commit intomainfrom
iennae-patch-2
Open

fix: remove empy confusing trace/trace-python-sample directory#13995
iennae wants to merge 1 commit intomainfrom
iennae-patch-2

Conversation

@iennae
Copy link
Copy Markdown
Contributor

@iennae iennae commented Apr 8, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@iennae iennae requested review from a team as code owners April 8, 2026 01:21
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudtrace Issues related to the Cloud Trace API. labels Apr 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated README file from the trace/trace-python-sample directory as part of a sample relocation. Feedback indicates that the links in the new destination README (trace/trace-python-sample-opentelemetry/README.rst) are currently incorrect and should be updated to point to the specific sample directory before this redirecting file is deleted.


The Cloud Trace samples have been moved.

[![Open in Cloud Shell](https://gstatic.com/cloudssh/images/open-btn.png)](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/python-docs-samples&page=editor&open_in_editor=trace/trace-python-sample-opentelemetry/README.rst)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Cloud Shell link in this file correctly points to the new sample directory. However, the links in the new README (trace/trace-python-sample-opentelemetry/README.rst, lines 7 and 74) appear to point to the parent trace/ directory instead. The new README should be updated with the correct paths before this redirecting file is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudtrace Issues related to the Cloud Trace API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant