Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kms/attestations/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cryptography==45.0.1
cryptography==46.0.6
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating to cryptography v46 is a breaking change for the code in this directory. Specifically, in kms/attestations/verify_attestation_chains.py on line 227, the call mfr_root_cert.subject.public_bytes(backends.default_backend()) will fail.

In cryptography 46.0.0, the public_bytes method on Name objects (returned by the .subject property) was updated to require an encoding argument (e.g., serialization.Encoding.DER) and the backend argument was removed. This will result in a TypeError at runtime because the backend object is no longer accepted.

Please update the code in verify_attestation_chains.py to use mfr_root_cert.subject.public_bytes(serialization.Encoding.DER) or pin the dependency to <46.0.0 until the code can be updated.

pem==21.2.0; python_version < '3.8'
pem==23.1.0; python_version > '3.7'
requests==2.31.0
2 changes: 1 addition & 1 deletion kms/snippets/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
google-cloud-kms==3.11.0
cryptography==45.0.1
cryptography==46.0.6
crcmod==1.7
jwcrypto==1.5.6
2 changes: 1 addition & 1 deletion privateca/snippets/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pytest==8.2.0
google-auth==2.38.0
cryptography==45.0.1
cryptography==46.0.6
backoff==2.2.1