GKE Infrastructure Extensions - #6893
Conversation
| [], | ||
| 'Additional flags to pass to gcloud container node-pools create. ' | ||
| 'Example: --gke_additional_nodepool_flags=--max-pods-per-node=250', | ||
| ) |
There was a problem hiding this comment.
I wonder what's @hubatish's take on these. How much effort it takes to support such flags natively in PKB, e.g. the --max-pods-per-node? Maybe we should create issues to track the longterm support of these flags.
There was a problem hiding this comment.
We would generally add support for flags individually - but this broad flag certainly does allow for more powerful variations without input, which is also something valuable y'all have been asking for. So I'm ok with allowing them & expect them to be used by other contractors as well.
|
/lgtm |
| if self.enable_aam: | ||
| cmd.args.append('--auto-monitoring-scope=ALL') | ||
|
|
||
| # --- PKB Extension: additional cluster create flags --- |
There was a problem hiding this comment.
unnecessary comment here about "PKB extension". Obviously this is a PKB extension. Could add something about "add arbitrary additional flags" & perhaps a usage example.
There was a problem hiding this comment.
will modify.
|
Please resolve merge conflicts |
3 participants
Files: 2 files modified (no new files)
perfkitbenchmarker/providers/gcp/flags.py— 3 new flagsperfkitbenchmarker/providers/gcp/google_kubernetes_engine.py—RemoteBuild()enhancement + GKE flag passthroughDescription: Extends PKB's GKE provider with three capabilities needed by downstream benchmarks:
--gke_additional_flags/--gke_additional_nodepool_flags— pass arbitrary flags togcloud container clusters createandnode-pools create(e.g.,--enable-pod-snapshots,--max-pods-per-node=250)--skip_container_image_build— skipRemoteBuild()when images are pre-built (needed for cross-architecture builds)RemoteBuild()support for--container_remote_build_config— usesgcloud builds submit --config <yaml> --substitutions _IMAGE=<tag>instead of--tag(needed for ARM64 cross-compilation via Cloud Build)