Repository navigation
Add Stop button to AudioWorklet demos missing one - #474
Open
Aditya30ag wants to merge 2 commits into
Open
Aditya30ag wants to merge 2 commits into
Aditya30ag wants to merge 2 commits into
Conversation
Contributor
Author
|
@hoch please have a look |
Member
|
Thanks for your work on this, @Aditya30ag! We are currently working on a redesign of the site. We’ll keep this PR in mind and revisit implementing the stop-button functionality once the new structure is in place. |
Contributor
Author
|
Thanks for the update! Sounds good. |
Contributor
Author
|
Hi @hoch, just wanted to follow up on this PR. Has there been any update on the site redesign or on revisiting the stop-button functionality? I’d be happy to help with this if there’s anything I can do or if the changes need to be updated to fit the new structure. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several AudioWorklet demos only provide a START button, with no way to stop playback without reloading the page.
Add a visible STOP button to the affected demos. The button should suspend the audio context and re-enable START. Also guard worklet loading and graph setup so repeated starts do not rebuild the audio graph.
Before -
After -