Skip to content

Get CI passing again: pin the runner and steady the days-left test - #46

Merged
AndrewJMason merged 3 commits into
mainfrom
claude/days-left-test-clock
Oct 26, 2026
Merged

AndrewJMason merged 3 commits into
mainfrom
claude/days-left-test-clock

Conversation

@AndrewJMason

@AndrewJMason AndrewJMason commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Main's checks fail for three separate reasons, and Heroku waits for CI on main, so nothing deploys until all three are fixed. Any one alone still leaves the check red, so they're in one PR as three commits.

  • Pin the CI runner to ubuntu-24.04. GitHub moved ubuntu-latest to Ubuntu 26.04, and setup-ruby has no Ruby 3.4.3 there, so every job stopped at "Set up Ruby" before a single test ran (see Combine nine Dependabot gem updates into one deploy #45). The last green run on main, Oct 17, used 24.04.
  • Steady Admin::DashboardTest's days-left check. The test's drive closes 2.weeks.from_now, which keeps the clock time, so across the Nov 1 fall-back the span is 14 days and an hour, and Event#days_remaining rounds it up to 15. The test now sets the close to exactly 14 days of seconds from now.
  • Update crass to 1.0.8. bundler-audit flags crass 1.0.7 (GHSA-pq4g-8rxf-4g29, a CSS sanitizer bypass). It comes in through loofah, Rails' HTML sanitizer. Lockfile only.

No visual change. Merge this before #45, then update #45's branch so its checks rerun.

Not here: moving to a Ruby that Ubuntu 26.04 supports, which would also change production's Ruby. And Event#days_remaining itself, which can read one day high for about an hour a day in the two weeks before the fall clock change.

Testing: locally, the full suite on main is 507 runs / 1 failure (the days-left test); on this branch 507 / 0. bundler-audit, Brakeman, and RuboCop clean. On this PR the runner pin already let lint, scan_js, test, and system-test pass; scan_ruby failed only on crass.

🤖 Generated with Claude Code

smallpondproductions and others added 2 commits October 26, 2026 11:30
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AndrewJMason AndrewJMason changed the title Keep the dashboard days-left test steady across the fall clock change Get CI passing again: pin the runner and steady the days-left test Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AndrewJMason
AndrewJMason merged commit b556dc9 into main Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants