Repository navigation
Get CI passing again: pin the runner and steady the days-left test - #46
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's checks fail for three separate reasons, and Heroku waits for CI on main, so nothing deploys until all three are fixed. Any one alone still leaves the check red, so they're in one PR as three commits.
ubuntu-latestto Ubuntu 26.04, and setup-ruby has no Ruby 3.4.3 there, so every job stopped at "Set up Ruby" before a single test ran (see Combine nine Dependabot gem updates into one deploy #45). The last green run on main, Oct 17, used 24.04.2.weeks.from_now, which keeps the clock time, so across the Nov 1 fall-back the span is 14 days and an hour, andEvent#days_remainingrounds it up to 15. The test now sets the close to exactly 14 days of seconds from now.No visual change. Merge this before #45, then update #45's branch so its checks rerun.
Not here: moving to a Ruby that Ubuntu 26.04 supports, which would also change production's Ruby. And
Event#days_remainingitself, which can read one day high for about an hour a day in the two weeks before the fall clock change.Testing: locally, the full suite on main is 507 runs / 1 failure (the days-left test); on this branch 507 / 0. bundler-audit, Brakeman, and RuboCop clean. On this PR the runner pin already let lint, scan_js, test, and system-test pass; scan_ruby failed only on crass.
🤖 Generated with Claude Code