feat: add Claude adaptive thinking effort support for Bedrock Converse#22
feat: add Claude adaptive thinking effort support for Bedrock Converse#22SalemBajjali wants to merge 55 commits into
Conversation
…emplates and registry
…py, only set additionalModelRequestFields when effort is provided
| """Raised when the effort parameter is not a valid value.""" | ||
|
|
||
|
|
||
| class _EffortLevel(Enum): |
There was a problem hiding this comment.
Wagner Lab TODO: Check error messaging
korikuzma
left a comment
There was a problem hiding this comment.
Code looks good to me. @mcannon068nw is going to create a notebook to test this out! Once he confirms, I think we should be good to go.
|
This PR is stale because it has been open 3 day(s) with no activity. Please review this PR. |
|
Working on a notebook to test this now. One error I got right away:
I think we might want to put in the documentation somewhere that if using this parameter, temp must be fixed (if its not already there). |
|
Picked a variant, disease pairing that some searching told me could go one way or another for variant classification efforts based on whatever contexts might be around it. I used this to see if effort parameter differences changed the response it gave for LOW MED HIGH and MAX in Sonnet. Sonnet does not support Max but left it in to see how messy the error was. I got errors for MED HIGH and MAX, only LOW returned a valid response. Left these print outs in and committed the notebook for you to look through @SalemBajjali @korikuzma |
Closes #9
I followed the AWS Bedrock Converse documentation for adaptive thinking:
The implementation adds the required thinking configuration and optional effort setting under additionalModelRequestFields, matching the Converse API example.
I also added tests to cover the new effort configuration.