fix(robot): OfflineARXInterface must pass keymap_mode - #574
Draft
ElmoPA wants to merge 2 commits into
Draft
Conversation
Eva.get_keymap() requires keymap_mode, so the bare call raised TypeError and --offline-debug died before yielding a single observation. Present identically on main, bf/9-rh-h264 and _integ, so the offline path has not been exercised since get_keymap gained the argument. Threaded as a constructor arg rather than hardcoded, since the interface is shared across rollouts.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 17, 2026
The per-frame reader indexes images by frame; an h264 episode stores them
chunk-indexed (images.front_1 shape [5] = 5 chunks x 300 frames), so any frame
past the chunk count died with
IndexError: index 0 is out of bounds for axis 0 with size 0
from inside the zarr layer, naming neither the dataset nor the cause. Check the
image length against total_frames up front and point at the per-frame JPEG copy
of the same episode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eva.get_keymap() requires keymap_mode, so the bare call raised TypeError and
--offline-debug died before yielding a single observation. Present identically
on main, bf/9-rh-h264 and _integ, so the offline path has not been exercised
since get_keymap gained the argument.
Threaded as a constructor arg rather than hardcoded, since the interface is
shared across rollouts.