replace tqdm and async progress with richpool (resolves #76) - #77
Open
sahiljhawar wants to merge 1 commit into
Open
replace tqdm and async progress with richpool (resolves #76)#77sahiljhawar wants to merge 1 commit into
sahiljhawar wants to merge 1 commit into
Conversation
sahiljhawar
requested review from
DoctorRabbit55
and
a lite review from Copilot
and removed request for
Copilot
August 14, 2026 08:58
Collaborator
|
Thanks, Sahil! Can you please verify that this is equally fast as before? I had bad experiences with p_tqdm regarding speed in the past |
Contributor
Author
|
I have checked locally. the speed change is negligible. |
Collaborator
|
I think this is a better way to generate the progress bar for parallel tasks, but I would rather keep tqdm for simple for loops, as it does not require wrapping your loop into a function. |
Contributor
Author
|
just want to make it consistent :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
multiprocessing.Pooland manualtqdm-polling withrichpoolSwaps every
Pool/map_async+ manualtqdm-polling progress bar forrichpool.p_map(parallel) orrichpool.t_map/make_progress(sequential) acrossinterp_functions.py,bin_and_interpolate_to_model_grid.py, andmagnetic_field_functions.py. Removes the now-deadshow_process_bar_for_map_asynchelper and its unreachableisinstance(result, Exception)checks. worker exceptions already propagate throughp_mapthe same way they did throughPool.map_async(...).get(). Addsrichpoolas a dependency inpyproject.toml.Resolves #76.