Skip to content

[ENHANCEMENT] Refactor scoring system to improve moddability #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nykwono wants to merge 2 commits into
base: develop
Choose a base branch
from
+385 −346
Open

[ENHANCEMENT] Refactor scoring system to improve moddability #7754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b61514d
Change how scoring is handled, allowing people to use any system they…
nykwono Jul 5, 2026
e72d46c
remove accidental doc comment, remove unused variables.
nykwono Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions source/funkin/play/PlayState.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import funkin.play.notes.Strumline;
import funkin.play.notes.SustainTrail;
import funkin.play.notes.NoteVibrationsHandler;
import funkin.play.scoring.Scoring;
import funkin.play.scoring.ScoringPBOT1;
import funkin.play.song.Song;
import funkin.play.stage.Stage;
import funkin.save.Save;
Expand Down Expand Up @@ -447,6 +448,11 @@ class PlayState extends MusicBeatSubState
*/
public var currentConversation:Null<Conversation>;

/**
* The current scoring system used for judging and calculating scores.
*/
public var scoring = new ScoringPBOT1();

/**
* Key press inputs which have been received but not yet processed.
* These are encoded with an OS timestamp, so we can account for input latency.
Expand Down Expand Up @@ -3117,8 +3123,8 @@ class PlayState extends MusicBeatSubState
// Round inward (trim remainder) for consistency.
var noteDiff:Int = Std.int(Conductor.instance.songPosition - note.noteData.time - inputLatencyMs);

var score = Scoring.scoreNote(noteDiff, PBOT1);
var daRating = Scoring.judgeNote(noteDiff, PBOT1);
var score = scoring.scoreNote(noteDiff);
var daRating = scoring.judgeNote(noteDiff);

var healthChange = 0.0;
var isComboBreak = false;
Expand Down Expand Up @@ -3184,7 +3190,7 @@ class PlayState extends MusicBeatSubState
}
}

applyScore(Scoring.getMissScore(), 'miss', healthChange, true);
applyScore(scoring.getMissScore(), 'miss', healthChange, true);

if (playSound)
{
Expand Down
Loading
Loading