Fix trailing slash removed while typing#9316
Open
PikachuEXE wants to merge 2 commits into
Open
Conversation
1bcb7a3 to
39854c7
Compare
94056b4 to
9afbb6e
Compare
Contributor
|
In the Invidious API URL, if I type |
Member
Author
|
I have no idea what to do with those invalid values |
Contributor
|
Indeed, invalid values handling is probably more #3161 (comment) than #8228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Better version of #3776
If this works can do the same for #8228
Closes #8228
Description
FT was updating value on typing (even with debounce)
So this PR updates on blur (should be typing/pasting ended) instead of
inputeventScreenshots
Test yourself to be accurate~
Testing
#3303 (comment)
Desktop
Additional context
Draft coz dunno how to make it also update input value on blur (even it's already committed
Edit 1: Used
setTextbut dunno if that's properEdit 2: It seems
setTextis needed due to if sanitized value is set already (no slash) and slash value is input, the stored value is NOT updated and thus won't make input component to refresh its displayed input dataIf a new value is input then the input data is updated