Feature: Add fallback behavior for RSS ratelimiting "Closes #8653"#9157
Feature: Add fallback behavior for RSS ratelimiting "Closes #8653"#9157laclcia wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
PR: waiting for review
|
YT/FT broken on getting videos on sub just this hour (no issue a few hours ago |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Briefly tested with dev merged, a few things I can think of:
- Might be better to place the new setting below/above the RSS one (no sure about which one is better)
- New setting should be disabled when RSS one enabled
Also still wondering if we need a new setting instead of:
If size > 125 then use new batching logic instead of RSS
Else all done in one batch
No sure why we still need to auto switch to RSS with this new method added
|
I think it'd make sense to implement some of this logic for SubscriptionPosts (which doesn't support RSS but could support this chunking of requests when RSS is force enabled and Limit Fallback Request is set) |
|
Please rebase into dev branch |
4 participants
Pull Request Type
Related issue
8653
Description
this add's a toggle in the subscription section of the settings page (default off) witch when enabled will change the behavior when fetching subscriptions for large (above 125) lists. instead of falling back to RSS witch often has problems as YT's rss goes down often it will instead chunk fetch requests in chunk's of 80 separated by 2 seconds (2000 ms) to avoid rate limiting without relying on rss.
Screenshots
Testing
1 launch app and refresh a large subscription list. the RSS fetch should still work.
2 go to settings tab and the subscription subsection and check "limit request fallback without RSS"
3 go back to subscriptions and refresh. you should notice the bottom loading bar stopping for 2 sec then resuming (and stopping again since it fetches in chunk's of 80) a few times.
4 once all subscriptions are fetched they should all have timestamps confirming it worked without rss.
Desktop
Additional context
i originally created a proof of concept for this about a month ago and posted the diff in the original feature request thread here #8653 (comment) . i have been running that fix daily on my computers (and some friends) since then and it work's without problem.
English is a second language for me and i am not a developer by trade. this is the second pull request i have made (the first was for a one line fix for another most likely abandoned project). i have tried to the best of my ability to follow the guidelines in the "Code Contributions" file.