gitIssue-374 Fix remaining deprecated ${var} string interpolation in sources

[BradKollmyer]

Fixes FreePBX/issue-tracker#1313.

PHP 8.2 deprecates "${var}" inside double-quoted strings. The deprecation is raised at compile time when the file is included, and the FreePBX bootstrap's Whoops error handler escalates it to an ErrorException — so a source file containing the syntax throws on include, before its class can be instantiated. In practice this makes the LDAP source unusable on FreePBX 17 no matter how it is configured.

The sweep from #988/#989 (PR #371, shipped in 17.0.6) removed most occurrences; this completes it. Mechanical ${var} → {$var} on the five remaining lines:

File	Lines
sources/source-LDAP.module	177, 185
sources/source-CapsuleCRM.module	117
sources/source-Send_to_MythTV.module	73
sources/source-Send_to_YAC.module	37

No behavior change — {$var} produces identical output on all supported PHP versions.

Tested: all four files pass php -l on PHP 8.2.28 (Debian 12). The LDAP source fix is additionally verified end-to-end on a production FreePBX 17.0 / superfecta 17.0.7 install: with the patched file, a scheme debug run returns the correct CNAM from an LDAP phonebook in ~13 ms; unpatched, the include throws Whoops\Exception\ErrorException: Using ${var} in strings is deprecated.

🤖 Generated with Claude Code

[sangoma-oss-cla]

All committers have signed the CLA.

[BradKollmyer]

Gentle nudge on this one — it's been open a couple of weeks with no review.

Still reproducible on release/17.0 as it stands today: sources/source-LDAP.module
lines 177 and 185 continue to use ${var} interpolation.

177:  $dn = "ou=${ou},${dc}";
185:  $dn = "${dc}";

On PHP 8.2 — which is what FreePBX 17 ships on for Debian 12 — that deprecation
becomes a fatal exception on include under the Whoops handler, so the LDAP source
cannot run at all. It isn't a cosmetic warning; the source is simply unusable
until the file is patched by hand, and hand-patching trips the module signature
check and gets reverted by the next module update.

The change is 5 lines across 4 files (LDAP, CapsuleCRM, Send_to_MythTV,
Send_to_YAC) and is the same mechanical fix as the earlier #988/#989 sweep,
which just missed these. CLA is signed and the branch is mergeable.

Happy to split the LDAP fix out into its own PR if bundling the other three
sources is what's holding it up — just say the word.