[1.0.0] Add the core logic for replica password policy handling.#210
Merged
ChadSikorra merged 1 commit intoJul 11, 2026
Merged
Conversation
A replica should maintain local state for password policy to correctly enforce lockouts without having to rely on upstream replication to enforce it. Upstream will eventually converge (and we will forward the events upstream). But the replica must not give malicious actors unlimited password attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replica should maintain local state for password policy to correctly enforce lockouts without having to rely on upstream replication to enforce it. Upstream will eventually converge via journaling (and we will forward the events upstream). But the replica must not give malicious actors unlimited password attempts.
This is only part 1. A follow up PR will add the PDO implementation, which needs new schema + the write handling. Additionally, the forwarding of password policy events (attempts / locks / etc) is another follow up PR, as it will rollup and be forwarded in a background task similar to how the journal already has a background task for pruning. That will reduce the amount of traffic getting sent to the upstream primary and also allow it to gracefully handle the case where the upstream may be down or unavailable.