Fix: restore default appearance when clearing items - #63
Open
CYFish wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves how Fashion Sense restores colors when an appearance is cleared or when a saved color value is missing.
It is related to #61.
Changes
Expected behavior
Scope
This PR does not change Fashion Sense's current shared color-key design. Colors are still stored by appearance type and mask layer, so changing one dyeable shirt or pair of pants can still affect other appearances that use the same color key.
Testing
dotnet build FashionSense/FashionSense.sln(0, 0, 100)restores the original content-pack colors