Fix vertex mesh compilation with geometry tables. - #882
Merged
Merged
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue I was already aware of due to work in Dolfinx-adjoint and FEniCSx_ii (reported by @finsberg).
Evaluating spatial coordinates on a point mesh has been broken for a while in FFCx.
This was also reported in: #879
The issue in the existing code is that the coordinate element of a point mesh is a DG-0 function.
This returns a basis table of a single number (1), which is correctly classified in the table generator as ttype="ones".
However, in FFCx we drop all "ones" and "zeros" tables, and therefore have to manually handle code generation for those cases.
This PR fixes this for coordinate dofs. The new generated code becomes:
for a 3D point.
AI disclosure
The test was manually implemented by me.
The fix was created with the help of CLAUDE (Opus 5). The code has been revised and simplified by me.