Switch CI type checking from mypy to Pyrefly - #4500
Open
garth-wells wants to merge 23 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| print("pyvista and pyvistaqt are required to visualise the solution") | ||
| have_pyvista = False | ||
| pv = None | ||
| pvqt = None |
garth-wells
marked this pull request as ready for review
September 13, 2026 20:30
| x0: npt.NDArray[np.inexact] | Sequence[npt.NDArray[np.inexact]], | ||
| x1: PETSc.Vec, | ||
| ) -> None: | ||
| ) -> None: ... |
| def assign( | ||
| x0: PETSc.Vec, | ||
| x1: npt.NDArray[np.inexact] | Sequence[npt.NDArray[np.inexact]], | ||
| ) -> None: ... |
|
|
||
|
|
||
| @overload | ||
| def assign(u: _Function | Sequence[_Function], x: PETSc.Vec) -> None: ... |
|
|
||
|
|
||
| @overload | ||
| def assign(u: PETSc.Vec, x: _Function | Sequence[_Function]) -> None: ... |
Member
|
Looks good, mypy was missing some odd things. Is it possible to put the config largely back into pyproject? Prefer the single file approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
AI assistance
AI assistance: OpenAI Codex drafted parts of this PR. Human review is pending before marking it ready.