Add item requests and gateway#3
Merged
Merged
Conversation
litvitnik
reviewed
Jul 1, 2025
| @@ -0,0 +1,7 @@ | |||
| logging.level.org.springframework.web.client.RestTemplate=DEBUG | |||
| #logging.level.org.apache.http=DEBUG | |||
There was a problem hiding this comment.
Тут остались закоментированные конфиги
litvitnik
reviewed
Jul 1, 2025
| import java.util.Optional; | ||
|
|
||
| public enum BookingState { | ||
| // Все |
There was a problem hiding this comment.
Лучше на javadoc бы переделать вместо комментов - будет чуть удобнее ориентироваться)
litvitnik
reviewed
Jul 1, 2025
| @Autowired | ||
| private ObjectMapper objectMapper; | ||
|
|
||
| private static final String USER_ID_HEADER = "X-Sharer-User-Id"; |
There was a problem hiding this comment.
Вот его бы в целом сделать константой для всех мест, где он используется в проекте :) Поскольку для server и gateway модули разные - то в каждом бы и завести по такой константе
litvitnik
reviewed
Jul 1, 2025
| } | ||
|
|
||
| @GetMapping("/{bookingId}") | ||
| public ResponseEntity<Object> getBooking(@RequestHeader("X-Sharer-User-Id") long userId, |
There was a problem hiding this comment.
Комментарий про константы относится к местам вроде вот этого
Owner
Author
|
@litvitnik Виталий, благодарю за проверку и отдельно за ценные советы 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.