Skip to content

feat: add RisingSunLight's GB mirror - #1165

Merged
SnipUndercover merged 3 commits into
EverestAPI:devfrom
Vireth4114:dev
Aug 27, 2026
Merged

feat: add RisingSunLight's GB mirror#1165
SnipUndercover merged 3 commits into
EverestAPI:devfrom
Vireth4114:dev

Conversation

@Vireth4114

@Vireth4114 Vireth4114 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Adds a new GameBanana mirror at https://library.risingsunlight.dev/celeste/mods/ which updates every 30 minutes

Jointly with Olympus PR EverestAPI/Olympus#167

@Vireth4114 Vireth4114 mentioned this pull request Aug 24, 2026
Closed
@SnipUndercover

SnipUndercover commented Aug 24, 2026

Copy link
Copy Markdown
Member

Where is this mirror located?

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Aug 24, 2026
@maddie480

maddie480 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Which APIs from maddie480.ovh does it use? To make sure I don't make breaking changes

@fantomitechno

fantomitechno commented Aug 24, 2026

Copy link
Copy Markdown

Which APIs from maddie480.ovh does it use? To make sure I don't make breaking changes

None

It runs https://github.com/fantomitechno/GamebananaCelesteMirror

@RisingSunLight42

RisingSunLight42 commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

That's CRAZY that everyone is replying for a mirror that is ran on my infrastructure lmao

So to answer both of you Snip and Maddie:

  • Located in France, Normandie, more precise location is basically doxing me because it's running on my NAS. Currently, files are served with copyparty (file server FOSS tool), behind Cloudflare using their tunnels. If Cloudflare is an issue in the long run (it will) I'll see to ditch it (it's planned but not for now 'cuz it's quite the headache)
  • No API as Simon replied. Purely on the script they made with me testing it during the past week. Feel free if you have any questions, but it should correctly serve the files requested (Vireth in their testing for this PR successfully downloaded ssc4)

Oh and for the reason it's not me doing the PR : Vireth had already experienced building Everest from source and I was about to go to sleep yesterday + we thought it was silly that someone else than me PR's it. Sorry if it brings confusion.

@SnipUndercover

SnipUndercover commented Aug 24, 2026

Copy link
Copy Markdown
Member

We already have an European mirror in Germany hosted by @0x0ade, but I suppose having more options won't hurt.
Sounds good then.

SnipUndercover
SnipUndercover reviewed Aug 24, 2026
View reviewed changes

@SnipUndercover SnipUndercover left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple of comments before approving.

Comment thread Celeste.Mod.mm/Content/Dialog/English.txt Outdated
Comment thread Celeste.Mod.mm/Content/Dialog/French.txt Outdated
Comment thread Celeste.Mod.mm/Mod/Core/CoreModuleSettings.cs Outdated
Comment thread Celeste.Mod.mm/Mod/Core/CoreModuleSettings.cs Outdated
@Vireth4114 @SnipUndercover
Apply suggestions from code review
7a7984b 
Co-authored-by: Snip <49392266+SnipUndercover@users.noreply.github.com>
@maddie480-bot

maddie480-bot commented Aug 24, 2026

Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Aug 27, 2026, 8:08 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Aug 24, 2026
@maddie480-bot

maddie480-bot commented Aug 27, 2026

Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Aug 27, 2026
@SnipUndercover
SnipUndercover merged commit c64eda0 into EverestAPI:dev Aug 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microlith57 microlith57 microlith57 approved these changes
@SnipUndercover SnipUndercover SnipUndercover approved these changes

Assignees

No one assigned

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Vireth4114 @SnipUndercover @maddie480 @fantomitechno @RisingSunLight42 @maddie480-bot @microlith57