Skip to content

Add secret scanning workflow with Gitleaks - #2

Closed
crypto-titan wants to merge 1 commit into
mainfrom
crypto-titan-patch-1
Closed

Add secret scanning workflow with Gitleaks#2
crypto-titan wants to merge 1 commit into
mainfrom
crypto-titan-patch-1

Conversation

@crypto-titan

Copy link
Copy Markdown

This workflow enforces secret scanning using Gitleaks on pull requests and pushes to the main branch, including a canary test for planted secrets.

Summary

Checklist

  • pnpm test:all (or the CI-covered subset relevant to this change) passes locally.
  • No seed phrases, master XPrvs, or other recovery secrets are sent to hosted services, logs, URLs, storage, or React/server payloads.
  • The proof claim stays narrow: derivability of a payment credential from a master XPrv at a CIP-1852 path — nothing in this change overstates it.
  • If this touches verifier keys, proving keys, pinned hashes, Cardano export fixtures, contract parameters, or ceremony manifests: the whole coherence set was refreshed and verified together (pnpm verify:proof-release).
  • Security- or protocol-relevant changes include real derive/prove/verify/export or contract-path evidence with negative tests, not compile-only evidence.
  • New behavior is covered by tests that would fail without the change.

This workflow enforces secret scanning using Gitleaks on pull requests and pushes to the main branch, including a canary test for planted secrets.
secret-scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Action actions/checkout persist Git credentials in workflow - low severity
actions/checkout v2 and above persist the default GITHUB_TOKEN in the repository's local git config when persist-credentials is not set to false, during the workflow run. Subsequent workflow steps or third-party actions can read this token from git configuration, increasing the risk of credential theft or misuse within the pipeline. In order to limit the attack surface when external actions are compromised, ensure persist-credentials is set to false.

Show fix

Remediation: Set persist-credentials: false on actions/checkout steps that do not need to push commits back to the repository. Only keep persist-credentials: true when the workflow explicitly performs authenticated git push operations.

Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant