Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No standalone issue. Downstream Oracle work is tracked in Rustice #1198; the syntax changes are parser #46 and parser #47.
Rationale for this change
Consumers need a coherent DataFusion/sqlparser pair for typed warehouse statements and TABLE COMMENT = NULL while retaining the opt-in VALUES metadata resolver. The existing security audit also reports 15 inherited vulnerabilities in the workspace lockfile; the update resolves those findings without adding audit exceptions.
What changes are included in this PR?
Pin sqlparser and its derive package to qualified commit
3b740083360c8f757f2d8fb8029ebeef727194f8.Update the affected locked packages to compatible security fixes: ctutils 0.4.4, quinn-proto 0.11.18, rustls 0.23.46, rustls-webpki 0.103.16, zstd 0.13.4, zstd-safe 7.4.0 and zstd-sys 2.1.2+zstd.1.5.7. Quinn's upstream requirements add rand_pcg 0.10.2 and WASM RNG dependency edges for the existing getrandom 0.4.2. Other locked package records remain unchanged.
Only Cargo.toml and Cargo.lock differ from the base. All 1,701 DataFusion Rust files, including the VALUES hook and strict/equal-metadata fast paths, remain exact.
Are these changes tested?
Fresh qualification on the patched lock uses Rust 1.97.0, one build job and a 5/8/1 GiB memory-high/max/swap cap:
-D warnings) and the unmodified fulldev/rust_lint.shpass.309392b18f6b17022f82c701f300433126901068. The existing two ignore IDs remain unchanged.No fixture expectations changed. No result from the earlier parser-only or older dependency graphs is inherited.
Are there any user-facing changes?
The public parser AST adds warehouse statement variants and typed TABLE COMMENT = NULL; exhaustive downstream matches may require updates (
api changelabel applied). Warehouse execution and downstream admission remain separate work. Library consumers must resolve and qualify their own lockfiles; they do not inherit this workspace's Cargo.lock or audit result.