Skip to content

ColorPicker: Prevent selection after disabling - #23158

Open
Xapollon430 wants to merge 1 commit into
ElemeFE:devfrom
Xapollon430:codex/color-picker-disable-open-popup
Open

Xapollon430 wants to merge 1 commit into
ElemeFE:devfrom
Xapollon430:codex/color-picker-disable-open-popup

Conversation

@Xapollon430

Copy link
Copy Markdown
  • Followed the contribution guide.
  • Targets dev.
  • Described and reproduced the bug.

Problem

Open an enabled ColorPicker, then set its disabled prop while its popup is open. If you choose another color and confirm, the bound value still changes.

Fix

Close on disable and guard both confirm and clear.

Validation

A native Chromium headless shell action emitted one extra model update on dev and zero after the fix. The same fixture compiled and exercised the original and patched Vue 2 source.

Before and after recording

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant