fix(history): copy local schema messages without serialization - #288
Open
YaoxinHuang wants to merge 3 commits into
Open
YaoxinHuang wants to merge 3 commits into
YaoxinHuang wants to merge 3 commits into
Conversation
Replace loading of chat history with deepcopy of existing history.
Add a test to verify that copying history with a local schema is independent from the original history.
Add test for resetting history with local schema in AtomicAgent.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatHistory.copy()currently serializes and reimports message classes, so a history containing a schema defined inside a function raisesValueErrorand preventsAtomicAgentfrom initializing with that history. Deep-copy the messages directly, preserving the existing history type, limits, and turn ID; add regressions for nested copy independence and agent initialization/reset with a local schema.Validation: 341 tests passed, 3 MiniMax API tests skipped; repository-wide Black and Flake8 checks and all applicable changed-file pre-commit hooks passed. Both new regressions fail before the fix. Developed and tested with Codex assistance.