Skip to content

docs: run the actual skill suite in contributor test instructions - #718

Merged
Lum1104 merged 1 commit into
Egonex-AI:mainfrom
xiehuanyi:docs/skill-test-command-20261007
Oct 9, 2026
Merged

Lum1104 merged 1 commit into
Egonex-AI:mainfrom
xiehuanyi:docs/skill-test-command-20261007

Conversation

@xiehuanyi

Copy link
Copy Markdown
Contributor

Summary

The contributor guide uses pnpm --filter @understand-anything/skill test, but that package script only prints a reminder and does not run tests. Replace it with the root pnpm test command. Clarify that both the core command and root command are required for complete coverage, because the root Vitest config excludes core tests, and align the PR checklist with that split.

Linked issue(s)

Documentation correction verified against understand-anything-plugin/package.json, the root vitest.config.ts and .github/workflows/ci.yml.

How I tested this

  • pnpm lint
  • pnpm --filter @understand-anything/core test — 47 files, 1,013 tests passed
  • pnpm test — 38 files passed, 1 skipped; 786 tests passed, 12 skipped
  • Inspected package scripts and CI commands, and passed git diff --check

Versioning

  • N/A — documentation-only change

AI assistance: prepared with Codex and checked against the actual package scripts and both test commands.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 10:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Lum1104
Lum1104 merged commit ffa2f0a into Egonex-AI:main Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants