Repository navigation
docs: run the actual skill suite in contributor test instructions - #718
Merged
Lum1104 merged 1 commit intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The contributor guide uses
pnpm --filter @understand-anything/skill test, but that package script only prints a reminder and does not run tests. Replace it with the rootpnpm testcommand. Clarify that both the core command and root command are required for complete coverage, because the root Vitest config excludes core tests, and align the PR checklist with that split.Linked issue(s)
Documentation correction verified against
understand-anything-plugin/package.json, the rootvitest.config.tsand.github/workflows/ci.yml.How I tested this
pnpm lintpnpm --filter @understand-anything/core test— 47 files, 1,013 tests passedpnpm test— 38 files passed, 1 skipped; 786 tests passed, 12 skippedgit diff --checkVersioning
AI assistance: prepared with Codex and checked against the actual package scripts and both test commands.