Skip to content

fix(schema): reject the direction-inverting documented_by alias - #712

Open
xiehuanyi wants to merge 1 commit into
Egonex-AI:mainfrom
xiehuanyi:fix/documented-by-direction-653
Open

xiehuanyi wants to merge 1 commit into
Egonex-AI:mainfrom
xiehuanyi:fix/documented-by-direction-653

Conversation

@xiehuanyi

Copy link
Copy Markdown
Contributor

Summary

Stop converting file --documented_by--> document into file --documents--> document, which reverses the relationship. Following the existing implemented_by/tests policy, leave this inverse alias unnormalized so validation drops it with an invalid-edge issue; canonical documents edges retain their original endpoints.

Linked issue(s)

Closes #653.

How I tested this

Added regressions for reporting/dropping documented_by and preserving canonical documents edges. Core build also passes.

  • pnpm lint
  • pnpm --filter @understand-anything/core test — 1,015 passing
  • pnpm test — 786 passing, 12 skipped
  • Manual smoke test — covered by the deterministic graph validation regression

Versioning

  • Version bumped to 2.9.8 in all six manifests listed in CLAUDE.md

Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] EDGE_TYPE_ALIASES maps documented_by to documents without swapping endpoints, silently reversing the edge

2 participants