Improve restart history-option error messages (#3593)#4113
Open
enu-emu wants to merge 1 commit into
Open
Conversation
The three "you can NOT change history options on restart" errors in histFileMod.F90 stated the problem but not the remedy. Add guidance telling users to use a branch run instead, and clarify that the restriction applies to a continuation run. Message-text only; no logic change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3593.
The error raised when history options change across a restart told the user what was forbidden ("You can NOT change history options on restart") but not what to do about it. This adds guidance to use a branch run instead, and clarifies that the restriction applies to a continuation run.
While tracing the code I noticed the same phrasing appears in three sibling
endruncalls in the restart-read block ofhistFileMod.F90— thentapes,history_tape_in_use, and number-of-fields checks — so I updated all three for consistency. Happy to narrow it to just thentapesmessage if you'd prefer.This is a message-text-only change (no logic touched), so it should be bit-for-bit identical. One note: I wasn't able to build/run CTSM locally (M1 Mac, limited RAM/disk), so I verified this by code inspection and would appreciate it being checked via your regression testing.
🤖 Generated with Claude Code