Skip to content

ctsm5.4.049: Fix typo, 'expontential' --> 'exponential' in fates c starvation model #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slevis-lmwg merged 9 commits into from
Aug 3, 2026
+74 −1
Merged

ctsm5.4.049: Fix typo, 'expontential' --> 'exponential' in fates c starvation model #4093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbd0824
Fix typo, 'expotential' --> 'exponential' in fates c starvation model…
r-ward Jun 11, 2026
ac92a69
Merge tag 'ctsm5.4.046' into fix_cstarv_model_typo
glemieux Jul 2, 2026
a7811e0
add non-default carbon starvation testing to fates suite
glemieux Jul 2, 2026
a780cd4
Merge pull request #2 from glemieux/fix_cstarv_model_typo-addtest
r-ward Jul 2, 2026
b65c32e
Merge branch 'master' into fix_cstarv_model_typo
wwieder Jul 16, 2026
d14ea0f
Merge branch 'master' into fix_cstarv_model_typo
slevis-lmwg Jul 31, 2026
6d80971
Change the new izumi_nag test to ERP_D (debug) so it will build in nag
slevis-lmwg Aug 3, 2026
694d00b
Update ChangeLog/ChangeSum
slevis-lmwg Aug 3, 2026
5a0e53d
Add email and affiliation to ChangeLog entry
slevis-lmwg Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions cime_config/testdefs/testlist_clm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3890,6 +3890,24 @@
<option name="comment">ERP FATES test covering all standard FATES history variables.</option>
</options>
</test>
<test name="ERP_Ld90" grid="f45_f45_mg37" compset="I2000Clm60FatesRs" testmods="clm/FatesColdCStarvationExp">
<machines>
<machine name="derecho" compiler="intel" category="fates"/>
</machines>
<options>
<option name="wallclock">00:40:00</option>
<option name="comment">ERP FATES test covering FATES exponential carbon starvation (non-default)</option>
</options>
</test>
<test name="ERP_D_Ld90" grid="f45_f45_mg37" compset="I2000Clm60FatesRs" testmods="clm/FatesColdCStarvationExp">
<machines>
<machine name="izumi" compiler="nag" category="fates"/>
</machines>
<options>
<option name="wallclock">00:40:00</option>
<option name="comment">ERP_D FATES test covering FATES exponential carbon starvation (non-default), where the debug option _D allows the test to pass on izumi_nag</option>
</options>
</test>
Comment thread
slevis-lmwg marked this conversation as resolved.
<test name="ERS_D_Ld30" grid="f45_f45_mg37" compset="I2000Clm50FatesCruRsGs" testmods="clm/FatesColdPRT2">
<machines>
<machine name="derecho" compiler="intel" category="fates"/>
Expand Down
1 change: 1 addition & 0 deletions cime_config/testdefs/testmods_dirs/clm/FatesColdCStarvationExp/README
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This tests the non-default option for the FATES carbon starvation option
1 change: 1 addition & 0 deletions cime_config/testdefs/testmods_dirs/clm/FatesColdCStarvationExp/include_user_mods
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../FatesCold
1 change: 1 addition & 0 deletions cime_config/testdefs/testmods_dirs/clm/FatesColdCStarvationExp/user_nl_clm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fates_cstarvation_model = 'exponential'
51 changes: 51 additions & 0 deletions doc/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,55 @@
===============================================================
Tag name: ctsm5.4.049
Originator(s): r-ward (Rachel Ward, r.ward@berkeley.edu, UC Berkeley)
Date: Mon Aug 3 15:24:15 MDT 2026
One-line Summary: Fix typo 'expontential' to 'exponential' in fates c starvation model

Purpose and description of changes
----------------------------------

Fixes a typo in src/utils/clmfates_interfaceMod.F90 for the fates c starvation namelist option ("expontential" --> "exponential") that causes runs using fates_cstarvation_model=exponential (valid options =linear, exponential) to abort at init with error message "Invalid carbon starvation model".

Notes of particular relevance for users
---------------------------------------
Changes made to namelist defaults (e.g., changed parameter values):
Typo correction to the fates c starvation namelist option "exponential"

Contributors:
glemieux

Notes of particular relevance for developers:
---------------------------------------------
Changes to tests or testing:
Adding a derecho test and an izumi test to the fates test-suite:
ERP_Ld90.f45_f45_mg37.I2000Clm60FatesRs.derecho_intel.clm-FatesColdCStarvationExp
ERP_D_Ld90.f45_f45_mg37.I2000Clm60FatesRs.izumi_nag.clm-FatesColdCStarvationExP

Testing summary:
----------------

[PASS means all tests PASS; OK means tests PASS other than expected fails.]

regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):

derecho ----- OK
izumi ------- OK

fates tests: new baseline fates-sci.1.92.7_api.46.0.0-ctsm5.4.049 compared to existing baseline fates-sci.1.92.7_api.46.0.0-ctsm5.4.047
derecho ----- OK
izumi ------- OK

Answer changes
--------------

Changes answers relative to baseline: No

Other details
-------------
Pull Requests that document the changes (include PR ids):
https://github.com/ESCOMP/ctsm/pull/4093

===============================================================
===============================================================
Tag name: ctsm5.4.048
Originator(s): erik (Erik Kluzek)
Date: Fri Jul 31 02:44:53 PM MDT 2026
Expand Down
1 change: 1 addition & 0 deletions doc/ChangeSum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Tag Who Date Summary
============================================================================================================================
ctsm5.4.049 r-ward 08/03/2026 Fix typo 'expontential' to 'exponential' in fates c starvation model
ctsm5.4.048 erik 07/31/2026 Move b4b-dev to master
ctsm5.4.047 samrabin 07/10/2026 Merge b4b-dev to master
ctsm5.4.046 glemieux 06/22/2026 Remove variables to exclude for fates_sp user mod
Expand Down
2 changes: 1 addition & 1 deletion src/utils/clmfates_interfaceMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ subroutine CLMFatesGlobals2()

if (trim(fates_cstarvation_model) == 'linear') then
pass_cstarvation_model = 1
else if (trim(fates_cstarvation_model) == 'expontential') then
else if (trim(fates_cstarvation_model) == 'exponential') then
pass_cstarvation_model = 2
end if
call set_fates_ctrlparms('mort_cstarvation_model',ival=pass_cstarvation_model)
Expand Down
Loading