fix(queue): close virtqueue notification races - #11
Merged
Merged
Conversation
Signed-off-by: LoGin <longjin@DragonOS.org>
fslongjin
marked this pull request as ready for review
July 23, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u32used descriptor ID before narrowing or recycling descriptorsallocis enabled, avoiding large Q64 queue objects on kernel stacksRoot cause
With
VIRTIO_F_RING_EVENT_IDXnegotiated, disabling callbacks wrote a suppressedused_event, but every subsequentpop_used()unconditionally advancedused_eventagain. NAPI-style polling therefore reopened the interrupt stream partway through a bounded poll, causing IRQ/MISSED churn. In addition, raw net code validated a peeked used ID separately from the ID consumed bypop_used(), leaving a TOCTOU window and narrowing an untrustedu32ID too early.Impact
VirtIO net drivers can now implement the standard disable/poll/enable/recheck handshake without losing the callback state or accepting an invalid descriptor token. Queue construction for larger raw-net rings also avoids avoidable kernel-stack pressure.
Validation
cargo fmt --all -- --checkRUSTFLAGS='--cap-lints=warn' cargo testgit diff --checkThe
--cap-lints=warnsetting is required only because the repository's existing fake transport test module triggers pre-existingmissing_docslints.