JavaScript support#491
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
|
Hello there, I have a scope question. Do you envision networking Web APIs like P.S. I've been building an embedder on this branch for the past while. A React 18 + TS apps and a small real-world web app run end-to-end on blitz-script. (with a handful of local DOM additions: classList, closest, dataset, etc. — happy to send those as PRs if useful). |
|
I would definitely be interested to see a variant of this PR that can run React apps! That being said, I think this PR has architectural issues, and probably isn't mergeable in this form (+I still haven't gone through the whole thing in detail yet).
I'd guess we'd at least want to supply an implementation of these, but keep them optional. Whether it's in the same crate or a separate crate I don't know. |
|
Yeah, I hear you! Thanks! Here's the PR link with my additions: nicoburns/blitz@js-engine...devarda:blitz:react-dom-apis Here's my demo project: https://github.com/devarda/react-blitz-demo Mind you that my code was AI generated as well. I've been checking the outcomes and not the code. I haven't written any code for over 2 years now... Idk what to think of it xD Anyway, perhaps you can have your AI take a look at my AI's commits. I look forward to the end results of your work here! Best.
|
|
This is very cool! It's great news that React will run with a relatively small set of changes (I was expecting more to be required tbh). I imagine there are parts of React that still don't work here. But if it's usable then that's a really good start! Probably I should rename the example, so you don't have to run an example called
Alas, I am still committed to having human review on everything that goes into Blitz (which is also partly why this PR is still a draft - I haven't had a chance to review it yet either). Luckily the diff from your changes actually seems to be relatively small/manageable (~1k LoC), so I think I can review. I had a quick skim, and it looks pretty reasonable. |

This is an AI-generated implementation of JavaScript support for Blitz using the Boa JS engine. I have not yet reviewed the code.
Generated with Claude Fable XHigh