fix: tighten simplification marker rule#491
Open
sanmaxdev wants to merge 3 commits into
Open
Conversation
kydorn
reviewed
Jul 2, 2026
Addresses reviewer feedback to eliminate the ponytail: comment reference that creates confusion without prior context.
Contributor
Author
|
Good point about the confusing reference. Removed the ponytail: comment mention completely to avoid the 'pink elephant' problem.
|
kydorn
approved these changes
Jul 3, 2026
kydorn
reviewed
Jul 3, 2026
| - Question complex requests: "Do you actually need X, or does Y cover it?" | ||
| - Pick the edge-case-correct option when two stdlib approaches are the same size, lazy means less code, not the flimsier algorithm. | ||
| - Mark only deliberate simplifications that cut a real corner with a known ceiling (global lock, O(n²) scan, naive heuristic). Normal or trivial code gets no `ponytail:` comment; when a shortcut does need one, the comment names the ceiling and upgrade path. | ||
| - Mark deliberate simplifications that cut a real corner with a known ceiling (global lock, O(n²) scan, naive heuristic) with a comment naming the ceiling and upgrade path. |
There was a problem hiding this comment.
you need to apply this same change in ALL the other places.
Contributor
Author
|
Updated the copied rule text to match the new wording everywhere. Checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ponytail:comment.Testing
node scripts/check-rule-copies.jsnode scripts/check-versions.jsnode --test benchmarks/*.test.js pi-extension/test/helpers.test.js tests/hooks.test.js tests/openclaw-skills.test.jsnpm testgit diff --checkCloses #120