Skip to content

Run PR metadata validations in their own workflow - #25537

Closed
dkirov-dd wants to merge 2 commits into
masterfrom
dk/validate-pr-metadata-on-edit
Closed

dkirov-dd wants to merge 2 commits into
masterfrom
dk/validate-pr-metadata-on-edit

Conversation

@dkirov-dd

@dkirov-dd dkirov-dd commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Runs validations that only read pull request metadata in their own workflow, which also re-runs when the description is edited or labels change.

  • ValidationConfig gets pr_metadata, set on qa-label (the only metadata validation on master).
  • ddev validate all --scope [all|code|pr-metadata] (default all, so local runs are unchanged).
  • New validate-pr-metadata.yml, a thin caller of run-validations.yml with scope: pr-metadata. It runs on opened, synchronize, reopened, edited, labeled and unlabeled, with its own concurrency group. Its check is Run PR Metadata Validations / Validate.
  • validate.yml now uses scope: code and no longer triggers on labeled/unlabeled, which existed only for qa-label.
  • The metadata run posts its own PR comment, ## PR Metadata Validation Report. Neither run deletes the other's comment.

No new script; the self.validate.pull-request octo-sts policy already matches any caller of run-validations.yml.

Motivation

Follow-up to #25496 (review discussion with @AAraKKe). The upcoming pr-description validation needs to re-run when the description is edited. Adding edited to the existing workflow would cause problems:

  • an edit run that skips or narrows the suite replaces the latest Run Validations result, so earlier failures would no longer show
  • it would replace the full validation report comment
  • because of cancel-in-progress, every edit would cancel an in-progress full run, including the automatic edits the Jira integration makes

A separate workflow avoids all three. Label changes also stop re-running the whole suite.

pr-description would get pr_metadata=True once both PRs land. Verified here: editing this description re-ran only Run PR Metadata Validations.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Validations that only read pull request metadata (qa-label for now) run in a
new Validate PR metadata workflow, triggered also on description edits and
label changes. The main validation suite no longer re-runs on label changes,
and edits cannot cancel, mask, or overwrite its results.
@dkirov-dd dkirov-dd added the qa/skip-qa Automatically skip this PR for the next QA label Oct 7, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  2/2 jobs

✅ 2 passed · nothing failed

Batches · ✅ batch-01 2/2

Dispatcher finished on 52f7fec — GitHub Run · Dispatcher Logs.

@dd-octo-sts

dd-octo-sts Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (9 files):
  .github/workflows/run-validations.yml
  .github/workflows/validate-pr-metadata.yml
  .github/workflows/validate.yml
  AGENTS.md
  ddev/src/ddev/cli/validate/all/__init__.py
  ddev/src/ddev/cli/validate/all/github.py
  ddev/src/ddev/cli/validate/all/orchestrator.py
  ddev/tests/cli/validate/all/test_command.py
  ddev/tests/cli/validate/all/test_orchestrator.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Pipelines  Tests  Code Coverage

⚠️ Warnings

Your PR has warnings. Tests failed — unable to determine if these are from required jobs.

🚦 1 Pipeline job failed

PR All | test / j0c16521 / Istio

View more details · View in GitHub Actions

🧪 1 Test failed in 1 job

PR All | run — ❄️ 1 known flaky test · 🔄 may pass on retry

View more details · View in GitHub Actions

↳ ❄️ Known flaky: test_e2e_ambient from test_e2e.py   View in Datadog

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🔄 Datadog retried 2 tests - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.52% (+0.10%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f995f95 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Metadata Validation Report

All 1 validations passed.

Show details
Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅

View full run

@dkirov-dd dkirov-dd closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev dev/testing dev/tooling qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant