Repository navigation
Conversation
Validations that only read pull request metadata (qa-label for now) run in a new Validate PR metadata workflow, triggered also on description edits and label changes. The main validation suite no longer re-runs on label changes, and edits cannot cancel, mask, or overwrite its results.
Contributor
✅ Dispatcher tests: passed
✅ 2 passed · nothing failed Batches · ✅ batch-01 2/2 Dispatcher finished on |
Contributor
Validation ReportAll 20 validations passed. Show details
|
evalya-impact-summaryevalya impact analysis |
|
Contributor
PR Metadata Validation ReportAll 1 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runs validations that only read pull request metadata in their own workflow, which also re-runs when the description is edited or labels change.
ValidationConfiggetspr_metadata, set onqa-label(the only metadata validation on master).ddev validate all --scope [all|code|pr-metadata](defaultall, so local runs are unchanged).validate-pr-metadata.yml, a thin caller ofrun-validations.ymlwithscope: pr-metadata. It runs on opened, synchronize, reopened, edited, labeled and unlabeled, with its own concurrency group. Its check is Run PR Metadata Validations / Validate.validate.ymlnow usesscope: codeand no longer triggers onlabeled/unlabeled, which existed only forqa-label.## PR Metadata Validation Report. Neither run deletes the other's comment.No new script; the
self.validate.pull-requestocto-sts policy already matches any caller ofrun-validations.yml.Motivation
Follow-up to #25496 (review discussion with @AAraKKe). The upcoming
pr-descriptionvalidation needs to re-run when the description is edited. Addingeditedto the existing workflow would cause problems:cancel-in-progress, every edit would cancel an in-progress full run, including the automatic edits the Jira integration makesA separate workflow avoids all three. Label changes also stop re-running the whole suite.
pr-descriptionwould getpr_metadata=Trueonce both PRs land. Verified here: editing this description re-ran only Run PR Metadata Validations.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged